From ec5ebfce8ea4770631fc3715f4a1616c50797787 Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Tue, 21 May 2024 15:27:01 +0700 Subject: [PATCH 1/2] fix: Distance unit isn't updated immediately --- src/libs/Network/SequentialQueue.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libs/Network/SequentialQueue.ts b/src/libs/Network/SequentialQueue.ts index b94166c0249d..d7e3fecd5a1f 100644 --- a/src/libs/Network/SequentialQueue.ts +++ b/src/libs/Network/SequentialQueue.ts @@ -169,6 +169,9 @@ function push(request: OnyxRequest) { // If we are offline we don't need to trigger the queue to empty as it will happen when we come back online if (NetworkStore.isOffline()) { + isReadyPromise = new Promise((resolve) => { + resolveIsReadyPromise = resolve; + }); return; } From 530643958ddac7b6811352033d657e49c3774d01 Mon Sep 17 00:00:00 2001 From: nkdengineer Date: Wed, 22 May 2024 15:28:27 +0700 Subject: [PATCH 2/2] Do not resolve promise if persisted requests is not empty --- src/libs/Network/SequentialQueue.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/libs/Network/SequentialQueue.ts b/src/libs/Network/SequentialQueue.ts index d7e3fecd5a1f..bf68a694523a 100644 --- a/src/libs/Network/SequentialQueue.ts +++ b/src/libs/Network/SequentialQueue.ts @@ -129,7 +129,9 @@ function flush() { Onyx.disconnect(connectionID); process().finally(() => { isSequentialQueueRunning = false; - resolveIsReadyPromise?.(); + if (NetworkStore.isOffline() || PersistedRequests.getAll().length === 0) { + resolveIsReadyPromise?.(); + } currentRequest = null; flushOnyxUpdatesQueue(); }); @@ -169,9 +171,6 @@ function push(request: OnyxRequest) { // If we are offline we don't need to trigger the queue to empty as it will happen when we come back online if (NetworkStore.isOffline()) { - isReadyPromise = new Promise((resolve) => { - resolveIsReadyPromise = resolve; - }); return; }