From 7f7611dfb1ecf09fb7ffc02aef8c7bbc045fdc10 Mon Sep 17 00:00:00 2001 From: Amal Nazeem Date: Wed, 22 Sep 2021 19:19:53 -0400 Subject: [PATCH 1/2] Rename route so that we expect traditional query paramters (i.e. after ?) --- src/ROUTES.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ROUTES.js b/src/ROUTES.js index e09bb4e84986..5e6138669279 100644 --- a/src/ROUTES.js +++ b/src/ROUTES.js @@ -67,7 +67,7 @@ export default { getReportDetailsRoute: reportID => `r/${reportID}/details`, VALIDATE_LOGIN: 'v', VALIDATE_LOGIN_WITH_VALIDATE_CODE: 'v/:accountID/:validateCode', - LOGIN_WITH_SHORT_LIVED_TOKEN: 'transition/:accountID/:email/:shortLivedToken/:encryptedAuthToken/:exitTo', + LOGIN_WITH_SHORT_LIVED_TOKEN: 'transition', // This is a special validation URL that will take the user to /workspace/new after validation. This is used // when linking users from e.com in order to share a session in this app. From 434584ec094959cdd56cdf76df65e4cf5968f8e1 Mon Sep 17 00:00:00 2001 From: Amal Nazeem Date: Wed, 22 Sep 2021 20:26:25 -0400 Subject: [PATCH 2/2] Changing log line condition so we don't log the authToken in the query params --- src/libs/Navigation/NavigationRoot.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/Navigation/NavigationRoot.js b/src/libs/Navigation/NavigationRoot.js index 6c1c58fd8ba2..ad516ebf0f52 100644 --- a/src/libs/Navigation/NavigationRoot.js +++ b/src/libs/Navigation/NavigationRoot.js @@ -32,7 +32,7 @@ class NavigationRoot extends Component { const path = getPathFromState(state, linkingConfig.config); // Don't log the route transitions from OldDot because they contain authTokens - if (path.includes('/transition/')) { + if (path.includes('/transition')) { Log.info('Navigating from transition link from OldDot using short lived authToken'); } else { Log.info('Navigating to route', false, {path});