From 95bfa02234659043a27485a1d3d863831b02f13b Mon Sep 17 00:00:00 2001
From: Rory Abraham <rory@expensify.com>
Date: Thu, 23 Sep 2021 16:34:11 -0700
Subject: [PATCH] Add type-safety checks in navigation functions

---
 src/libs/Navigation/Navigation.js | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/src/libs/Navigation/Navigation.js b/src/libs/Navigation/Navigation.js
index ff55c65c5e95..12279df62d2e 100644
--- a/src/libs/Navigation/Navigation.js
+++ b/src/libs/Navigation/Navigation.js
@@ -38,6 +38,10 @@ function setDidTapNotification() {
  * @private
  */
 function openDrawer() {
+    if (!navigationRef.isReady()) {
+        console.debug('[Navigation] openDrawer failed because navigation ref was not yet ready');
+        return;
+    }
     navigationRef.current.dispatch(DrawerActions.openDrawer());
 }
 
@@ -46,6 +50,10 @@ function openDrawer() {
  * @private
  */
 function closeDrawer() {
+    if (!navigationRef.isReady()) {
+        console.debug('[Navigation] closeDrawer failed because navigation ref was not yet ready');
+        return;
+    }
     navigationRef.current.dispatch(DrawerActions.closeDrawer());
 }
 
@@ -65,6 +73,11 @@ function getDefaultDrawerState(isSmallScreenWidth) {
  * @param {Boolean} shouldOpenDrawer
  */
 function goBack(shouldOpenDrawer = true) {
+    if (!navigationRef.isReady()) {
+        console.debug('[Navigation] goBack failed because navigation ref was not yet ready');
+        return;
+    }
+
     if (!navigationRef.current.canGoBack()) {
         console.debug('Unable to go back');
         if (shouldOpenDrawer) {
@@ -81,6 +94,11 @@ function goBack(shouldOpenDrawer = true) {
  * @param {String} route
  */
 function navigate(route = ROUTES.HOME) {
+    if (!navigationRef.isReady()) {
+        console.debug('[Navigation] navigate failed because navigation ref was not yet ready');
+        return;
+    }
+
     if (route === ROUTES.HOME) {
         if (isLoggedIn) {
             openDrawer();
@@ -110,6 +128,11 @@ function navigate(route = ROUTES.HOME) {
  * @param {Boolean} shouldOpenDrawer
  */
 function dismissModal(shouldOpenDrawer = false) {
+    if (!navigationRef.isReady()) {
+        console.debug('[Navigation] dismissModal failed because navigation ref was not yet ready');
+        return;
+    }
+
     const normalizedShouldOpenDrawer = _.isBoolean(shouldOpenDrawer)
         ? shouldOpenDrawer
         : false;