From baa2f91ed697d758f692ab499582b5d64fe0d189 Mon Sep 17 00:00:00 2001 From: Shubham Agrawal Date: Sat, 15 Mar 2025 00:19:29 +0530 Subject: [PATCH 1/4] Fixed create report fields flow --- src/pages/workspace/reportFields/CreateReportFieldsPage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx b/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx index 2f9b762458bf..5dded469af68 100644 --- a/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx +++ b/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx @@ -81,7 +81,7 @@ function CreateReportFieldsPage({ errors[INPUT_IDS.TYPE] = translate('workspace.reportFields.reportFieldTypeRequiredError'); } - if (type === CONST.REPORT_FIELD_TYPES.TEXT && formInitialValue.length > CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH) { + if (type === CONST.REPORT_FIELD_TYPES.TEXT && !!formInitialValue && formInitialValue.length > CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH) { errors[INPUT_IDS.INITIAL_VALUE] = translate('common.error.characterLimitExceedCounter', { length: formInitialValue.length, limit: CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH, From 8a19fe8e56b682b245ea7f19e309dee79b47b688 Mon Sep 17 00:00:00 2001 From: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com> Date: Tue, 18 Mar 2025 18:54:01 +0530 Subject: [PATCH 2/4] Apply suggestions from code review --- src/pages/workspace/reportFields/CreateReportFieldsPage.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx b/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx index 5dded469af68..6df8605ecbe6 100644 --- a/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx +++ b/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx @@ -81,6 +81,7 @@ function CreateReportFieldsPage({ errors[INPUT_IDS.TYPE] = translate('workspace.reportFields.reportFieldTypeRequiredError'); } + // As formInitialValue can be undefined and ts can't identify this yet, we are using !!formInitialValue to check for that. if (type === CONST.REPORT_FIELD_TYPES.TEXT && !!formInitialValue && formInitialValue.length > CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH) { errors[INPUT_IDS.INITIAL_VALUE] = translate('common.error.characterLimitExceedCounter', { length: formInitialValue.length, From 02ff8a716565fce4583286bf6c9235f3454665d9 Mon Sep 17 00:00:00 2001 From: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com> Date: Tue, 18 Mar 2025 23:43:18 +0530 Subject: [PATCH 3/4] Update comment Co-authored-by: Vit Horacek <36083550+mountiny@users.noreply.github.com> --- src/pages/workspace/reportFields/CreateReportFieldsPage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx b/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx index 6df8605ecbe6..3391ec616c71 100644 --- a/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx +++ b/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx @@ -81,7 +81,7 @@ function CreateReportFieldsPage({ errors[INPUT_IDS.TYPE] = translate('workspace.reportFields.reportFieldTypeRequiredError'); } - // As formInitialValue can be undefined and ts can't identify this yet, we are using !!formInitialValue to check for that. + // formInitialValue can be undefined because the InitialValue component is rendered conditionally. If it's not been rendered when the validation is executed, formInitialValue will be undefined. if (type === CONST.REPORT_FIELD_TYPES.TEXT && !!formInitialValue && formInitialValue.length > CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH) { errors[INPUT_IDS.INITIAL_VALUE] = translate('common.error.characterLimitExceedCounter', { length: formInitialValue.length, From 1877474902cb605666d9bf405894a4c5a6c87438 Mon Sep 17 00:00:00 2001 From: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com> Date: Tue, 18 Mar 2025 23:50:52 +0530 Subject: [PATCH 4/4] Apply suggestions from code review --- src/pages/workspace/reportFields/CreateReportFieldsPage.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx b/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx index 3391ec616c71..af96aff6a7a8 100644 --- a/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx +++ b/src/pages/workspace/reportFields/CreateReportFieldsPage.tsx @@ -81,7 +81,8 @@ function CreateReportFieldsPage({ errors[INPUT_IDS.TYPE] = translate('workspace.reportFields.reportFieldTypeRequiredError'); } - // formInitialValue can be undefined because the InitialValue component is rendered conditionally. If it's not been rendered when the validation is executed, formInitialValue will be undefined. + // formInitialValue can be undefined because the InitialValue component is rendered conditionally. + // If it's not been rendered when the validation is executed, formInitialValue will be undefined. if (type === CONST.REPORT_FIELD_TYPES.TEXT && !!formInitialValue && formInitialValue.length > CONST.WORKSPACE_REPORT_FIELD_POLICY_MAX_LENGTH) { errors[INPUT_IDS.INITIAL_VALUE] = translate('common.error.characterLimitExceedCounter', { length: formInitialValue.length,