From 483a7552c5ac15119a365f3fe2dc015f63dfcc74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Ch=C3=A1vez?= Date: Tue, 8 Apr 2025 13:07:22 -0600 Subject: [PATCH 1/4] Enhance ReportNameValuePairs type by adding exportFailedTime property to track report export failure time. --- src/types/onyx/ReportNameValuePairs.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/types/onyx/ReportNameValuePairs.ts b/src/types/onyx/ReportNameValuePairs.ts index a73795e556ef..eac5abac3c71 100644 --- a/src/types/onyx/ReportNameValuePairs.ts +++ b/src/types/onyx/ReportNameValuePairs.ts @@ -6,6 +6,9 @@ import type * as OnyxCommon from './OnyxCommon'; type ReportNameValuePairs = OnyxCommon.OnyxValueWithOfflineFeedback<{ /** Whether the report is an archived room */ private_isArchived?: string; + + /** The time the report export failed */ + exportFailedTime?: string; }>; /** Collection of reportNameValuePairs, indexed by reportNameValuePairs_{reportID} */ From 172b3c8ac2d34254e7c029584b6319edc4deed51 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Ch=C3=A1vez?= Date: Tue, 8 Apr 2025 13:07:56 -0600 Subject: [PATCH 2/4] Add handling for exportFailedTime in getAction function to support report review action --- src/libs/SearchUIUtils.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/libs/SearchUIUtils.ts b/src/libs/SearchUIUtils.ts index 6e81cf1e618f..ab3cd3ea4f17 100644 --- a/src/libs/SearchUIUtils.ts +++ b/src/libs/SearchUIUtils.ts @@ -396,6 +396,11 @@ function getAction(data: OnyxTypes.SearchResults['data'], key: string): SearchTr return CONST.SEARCH.ACTION_TYPES.SUBMIT; } + const reportRNVP = data[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report?.reportID}`] ?? undefined; + if (reportRNVP?.exportFailedTime) { + return CONST.SEARCH.ACTION_TYPES.REVIEW; + } + return CONST.SEARCH.ACTION_TYPES.VIEW; } From 48a5d330c11319e01d99c2dd8963932b18739c1a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Ch=C3=A1vez?= Date: Tue, 15 Apr 2025 12:23:14 -0600 Subject: [PATCH 3/4] Add exportFailedTime to report draft validation --- src/libs/DebugUtils.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libs/DebugUtils.ts b/src/libs/DebugUtils.ts index 3c794d2558c6..d5f1487d5d46 100644 --- a/src/libs/DebugUtils.ts +++ b/src/libs/DebugUtils.ts @@ -628,6 +628,7 @@ function validateReportDraftProperty(key: keyof Report | keyof ReportNameValuePa welcomeMessage: CONST.RED_BRICK_ROAD_PENDING_ACTION, errors: CONST.RED_BRICK_ROAD_PENDING_ACTION, createReport: CONST.RED_BRICK_ROAD_PENDING_ACTION, + exportFailedTime: CONST.RED_BRICK_ROAD_PENDING_ACTION, }); } } From 8045c8432c49fca9c2a6454bc0f919648648dbae Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Ch=C3=A1vez?= Date: Tue, 15 Apr 2025 12:28:36 -0600 Subject: [PATCH 4/4] Add exportFailedTime case to report draft validation function --- src/libs/DebugUtils.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libs/DebugUtils.ts b/src/libs/DebugUtils.ts index d5f1487d5d46..69f863e33cb1 100644 --- a/src/libs/DebugUtils.ts +++ b/src/libs/DebugUtils.ts @@ -480,6 +480,7 @@ function validateReportDraftProperty(key: keyof Report | keyof ReportNameValuePa case 'isWaitingOnBankAccount': case 'isCancelledIOU': return validateBoolean(value); + case 'exportFailedTime': case 'lastReadSequenceNumber': case 'managerID': case 'lastActorAccountID':