From d6fc928638412f8ed77d23176e044ddb472f57c3 Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Tue, 15 Apr 2025 17:32:47 -0600 Subject: [PATCH 1/4] disable moved actions --- src/CONST.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/CONST.ts b/src/CONST.ts index 4af1d3c79a45..a6dfc205e06c 100755 --- a/src/CONST.ts +++ b/src/CONST.ts @@ -1227,8 +1227,6 @@ const CONST = { MERGED_WITH_CASH_TRANSACTION: 'MERGEDWITHCASHTRANSACTION', MODIFIED_EXPENSE: 'MODIFIEDEXPENSE', MOVED: 'MOVED', - MOVED_TRANSACTION: 'MOVEDTRANSACTION', - UNREPORTED_TRANSACTION: 'UNREPORTEDTRANSACTION', OUTDATED_BANK_ACCOUNT: 'OUTDATEDBANKACCOUNT', // OldDot Action REIMBURSED: 'REIMBURSED', REIMBURSEMENT_ACH_BOUNCE: 'REIMBURSEMENTACHBOUNCE', // OldDot Action From aae406d9c34284b43d82b721eb5c91695ab4c821 Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Tue, 15 Apr 2025 17:48:49 -0600 Subject: [PATCH 2/4] deprecate actions --- src/CONST.ts | 2 ++ src/libs/ReportActionsUtils.ts | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/CONST.ts b/src/CONST.ts index a6dfc205e06c..4af1d3c79a45 100755 --- a/src/CONST.ts +++ b/src/CONST.ts @@ -1227,6 +1227,8 @@ const CONST = { MERGED_WITH_CASH_TRANSACTION: 'MERGEDWITHCASHTRANSACTION', MODIFIED_EXPENSE: 'MODIFIEDEXPENSE', MOVED: 'MOVED', + MOVED_TRANSACTION: 'MOVEDTRANSACTION', + UNREPORTED_TRANSACTION: 'UNREPORTEDTRANSACTION', OUTDATED_BANK_ACCOUNT: 'OUTDATEDBANKACCOUNT', // OldDot Action REIMBURSED: 'REIMBURSED', REIMBURSEMENT_ACH_BOUNCE: 'REIMBURSEMENTACHBOUNCE', // OldDot Action diff --git a/src/libs/ReportActionsUtils.ts b/src/libs/ReportActionsUtils.ts index f53e99b52867..072040f7fa23 100644 --- a/src/libs/ReportActionsUtils.ts +++ b/src/libs/ReportActionsUtils.ts @@ -745,6 +745,8 @@ function isReportActionDeprecated(reportAction: OnyxEntry, key: st CONST.REPORT.ACTIONS.TYPE.REIMBURSEMENT_SETUP_REQUESTED, CONST.REPORT.ACTIONS.TYPE.DONATION, CONST.REPORT.ACTIONS.TYPE.REIMBURSED, + CONST.REPORT.ACTIONS.TYPE.UNREPORTED_TRANSACTION, + CONST.REPORT.ACTIONS.TYPE.MOVED_TRANSACTION, ]; if (deprecatedOldDotReportActions.includes(reportAction.actionName)) { Log.info('Front end filtered out reportAction for being an older, deprecated report action', false, reportAction); From cef4d811ac1a5045bb2162a6f7e85ebbdfd1553c Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Tue, 15 Apr 2025 17:50:01 -0600 Subject: [PATCH 3/4] add comment --- src/libs/ReportActionsUtils.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libs/ReportActionsUtils.ts b/src/libs/ReportActionsUtils.ts index 072040f7fa23..b19712758d9a 100644 --- a/src/libs/ReportActionsUtils.ts +++ b/src/libs/ReportActionsUtils.ts @@ -745,6 +745,8 @@ function isReportActionDeprecated(reportAction: OnyxEntry, key: st CONST.REPORT.ACTIONS.TYPE.REIMBURSEMENT_SETUP_REQUESTED, CONST.REPORT.ACTIONS.TYPE.DONATION, CONST.REPORT.ACTIONS.TYPE.REIMBURSED, + + // We're temporarily deprecating the actions below since the feature is still WIP and these actions are being shown as duplicated CONST.REPORT.ACTIONS.TYPE.UNREPORTED_TRANSACTION, CONST.REPORT.ACTIONS.TYPE.MOVED_TRANSACTION, ]; From 9ac4e336760298e00b69f571b94329100c30af04 Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Wed, 16 Apr 2025 12:43:18 -0600 Subject: [PATCH 4/4] update tests --- tests/utils/collections/reportActions.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/utils/collections/reportActions.ts b/tests/utils/collections/reportActions.ts index 9a05ba6ad992..21347ad65d27 100644 --- a/tests/utils/collections/reportActions.ts +++ b/tests/utils/collections/reportActions.ts @@ -31,6 +31,8 @@ const deprecatedReportActions: ReportActionName[] = [ CONST.REPORT.ACTIONS.TYPE.REIMBURSEMENT_REQUESTED, CONST.REPORT.ACTIONS.TYPE.REIMBURSEMENT_SETUP_REQUESTED, CONST.REPORT.ACTIONS.TYPE.DONATION, + CONST.REPORT.ACTIONS.TYPE.MOVED_TRANSACTION, + CONST.REPORT.ACTIONS.TYPE.UNREPORTED_TRANSACTION, ] as const; export default function createRandomReportAction(index: number): ReportAction {