From 4054c67af8ae41281b3093a5c7710e9fc376b6e1 Mon Sep 17 00:00:00 2001 From: Marc Glasser Date: Tue, 7 Dec 2021 12:36:33 -1000 Subject: [PATCH 1/4] dont use arrays for params --- src/libs/API.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/API.js b/src/libs/API.js index 94b48e42b454..60ebf7334203 100644 --- a/src/libs/API.js +++ b/src/libs/API.js @@ -489,7 +489,7 @@ function GetFullPolicy(policyID) { const commandName = 'Get'; const parameters = { returnValueList: 'policyList', - policyIDList: [policyID], + policyIDList: policyID, }; return Network.post(commandName, parameters); } From c6ad844498844ff8ed7da1ffff452d6b2fb6cb24 Mon Sep 17 00:00:00 2001 From: Marc Glasser Date: Tue, 7 Dec 2021 12:42:57 -1000 Subject: [PATCH 2/4] Normalize request parameters --- src/libs/Network.js | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/libs/Network.js b/src/libs/Network.js index d7d74b889bf6..fbf9bc9bd304 100644 --- a/src/libs/Network.js +++ b/src/libs/Network.js @@ -256,6 +256,23 @@ function canProcessRequestImmediately(request) { return lodashGet(request, 'data.shouldProcessImmediately', true); } +/** + * @param {Object} data + * @returns {Object} + */ +function normalizeData(data) { + const normalizedData = {}; + _.each(data, (value, key) => { + if (_.isArray(value)) { + normalizedData[key] = value.join(','); + return; + } + + normalizedData[key] = value; + }); + return normalizedData; +} + /** * Perform a queued post request * @@ -266,10 +283,11 @@ function canProcessRequestImmediately(request) { * @returns {Promise} */ function post(command, data = {}, type = CONST.NETWORK.METHOD.POST, shouldUseSecure = false) { + const normalizedData = normalizeData(data); return new Promise((resolve, reject) => { const request = { command, - data, + data: normalizedData, type, resolve, reject, From f12f6b1c5dd484013a726c42b362804c3ff30790 Mon Sep 17 00:00:00 2001 From: Marc Glasser Date: Tue, 7 Dec 2021 12:46:50 -1000 Subject: [PATCH 3/4] add comment --- src/libs/Network.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libs/Network.js b/src/libs/Network.js index fbf9bc9bd304..6af1f3561ad6 100644 --- a/src/libs/Network.js +++ b/src/libs/Network.js @@ -263,6 +263,7 @@ function canProcessRequestImmediately(request) { function normalizeData(data) { const normalizedData = {}; _.each(data, (value, key) => { + // FormData() on native does not support arrays so we send a string instead if (_.isArray(value)) { normalizedData[key] = value.join(','); return; From e28f6b0eb8d8b85985ee8220a7749018605ff322 Mon Sep 17 00:00:00 2001 From: Marc Glasser Date: Tue, 7 Dec 2021 12:58:02 -1000 Subject: [PATCH 4/4] undo --- src/libs/Network.js | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/src/libs/Network.js b/src/libs/Network.js index 6af1f3561ad6..d7d74b889bf6 100644 --- a/src/libs/Network.js +++ b/src/libs/Network.js @@ -256,24 +256,6 @@ function canProcessRequestImmediately(request) { return lodashGet(request, 'data.shouldProcessImmediately', true); } -/** - * @param {Object} data - * @returns {Object} - */ -function normalizeData(data) { - const normalizedData = {}; - _.each(data, (value, key) => { - // FormData() on native does not support arrays so we send a string instead - if (_.isArray(value)) { - normalizedData[key] = value.join(','); - return; - } - - normalizedData[key] = value; - }); - return normalizedData; -} - /** * Perform a queued post request * @@ -284,11 +266,10 @@ function normalizeData(data) { * @returns {Promise} */ function post(command, data = {}, type = CONST.NETWORK.METHOD.POST, shouldUseSecure = false) { - const normalizedData = normalizeData(data); return new Promise((resolve, reject) => { const request = { command, - data: normalizedData, + data, type, resolve, reject,