From 6851a8ced9102c5b00ca7a36bd36950e888d24f2 Mon Sep 17 00:00:00 2001 From: Shubham Agrawal Date: Thu, 31 Jul 2025 15:03:39 +0530 Subject: [PATCH 1/3] Fix ESLint warnings and update limit --- package.json | 2 +- src/pages/home/report/ReportActionsList.tsx | 2 +- src/pages/settings/Wallet/PaymentMethodList.tsx | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 2d5cace600b9..3acb6fb72203 100644 --- a/package.json +++ b/package.json @@ -46,7 +46,7 @@ "test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand", "perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure", "typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc", - "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=324 --cache --cache-location=node_modules/.cache/eslint", + "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=321 --cache --cache-location=node_modules/.cache/eslint", "lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh", "lint-watch": "npx eslint-watch --watch --changed", "shellcheck": "./scripts/shellCheck.sh", diff --git a/src/pages/home/report/ReportActionsList.tsx b/src/pages/home/report/ReportActionsList.tsx index acf4d7ed1399..0d703973a8a4 100644 --- a/src/pages/home/report/ReportActionsList.tsx +++ b/src/pages/home/report/ReportActionsList.tsx @@ -447,7 +447,7 @@ function ReportActionsList({ setIsScrollToBottomEnabled(true); }); }, - [report.reportID, reportScrollManager, setIsFloatingMessageCounterVisible, sortedVisibleReportActions, reportScrollManager], + [report.reportID, reportScrollManager, setIsFloatingMessageCounterVisible, sortedVisibleReportActions], ); // Clear the highlighted report action after scrolling and highlighting diff --git a/src/pages/settings/Wallet/PaymentMethodList.tsx b/src/pages/settings/Wallet/PaymentMethodList.tsx index ab0c1c3ac2b1..96d07840bb89 100644 --- a/src/pages/settings/Wallet/PaymentMethodList.tsx +++ b/src/pages/settings/Wallet/PaymentMethodList.tsx @@ -492,10 +492,11 @@ function PaymentMethodList({ styles.ph6, styles.paymentMethod, styles.badgeBordered, + styles.mt4, + styles.mt6, + styles.mb1, styles.textLabel, styles.colorMuted, - styles.mh8, - styles.mt6, filteredPaymentMethods, invoiceTransferBankAccountID, userWallet?.walletLinkedAccountID, From 98542bb575f4e97d9e459643fa14182f7da88eed Mon Sep 17 00:00:00 2001 From: Shubham Agrawal Date: Thu, 31 Jul 2025 15:06:23 +0530 Subject: [PATCH 2/3] Fix another warning --- .../MoneyRequestReportPreviewContent.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx b/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx index dec114089435..8d0ec21e6536 100644 --- a/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx +++ b/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx @@ -440,7 +440,7 @@ function MoneyRequestReportPreviewContent({ return CONST.REPORT.REPORT_PREVIEW_ACTIONS.PAY; } return getReportPreviewAction(violations, isIouReportArchived || isChatReportArchived, iouReport, policy, transactions, invoiceReceiverPolicy); - }, [isPaidAnimationRunning, violations, iouReport, policy, transactions, isIouReportArchived, reportActions, invoiceReceiverPolicy, isChatReportArchived]); + }, [isPaidAnimationRunning, violations, iouReport, policy, transactions, isIouReportArchived, invoiceReceiverPolicy, isChatReportArchived]); const addExpenseDropdownOptions = useMemo( () => [ From 50e99371795e8f59754e9753a3c9744d56577e5a Mon Sep 17 00:00:00 2001 From: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com> Date: Fri, 1 Aug 2025 13:39:41 +0530 Subject: [PATCH 3/3] Apply suggestions from code review --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index fe017fe69208..50cc3a255de3 100644 --- a/package.json +++ b/package.json @@ -46,7 +46,7 @@ "test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand", "perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure", "typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc", - "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=328 --cache --cache-location=node_modules/.cache/eslint", + "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=329 --cache --cache-location=node_modules/.cache/eslint", "lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh", "lint-watch": "npx eslint-watch --watch --changed", "shellcheck": "./scripts/shellCheck.sh",