From b30fc378f998270aa69d1d311204672a87340546 Mon Sep 17 00:00:00 2001 From: Gandalf Date: Fri, 1 Aug 2025 13:37:14 +0530 Subject: [PATCH 1/3] Update HttpUtils.ts to remove usage of Onyx.connect --- src/libs/HttpUtils.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libs/HttpUtils.ts b/src/libs/HttpUtils.ts index 13e6542736a4..ab1975829038 100644 --- a/src/libs/HttpUtils.ts +++ b/src/libs/HttpUtils.ts @@ -22,7 +22,8 @@ const ABORT_COMMANDS = { type AbortCommand = keyof typeof ABORT_COMMANDS; -Onyx.connect({ +// We have used `connectWithoutView` here because OnyxUpdates is not connected to any UI +Onyx.connectWithoutView({ key: ONYXKEYS.NETWORK, callback: (network) => { if (!network) { From d80d77c56d5f17f9fe8d01fe60ae371ad247e7cb Mon Sep 17 00:00:00 2001 From: Gandalf Date: Fri, 1 Aug 2025 13:38:48 +0530 Subject: [PATCH 2/3] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 726f2e510739..59baaa27baf7 100644 --- a/package.json +++ b/package.json @@ -46,7 +46,7 @@ "test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand", "perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure", "typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc", - "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=331 --cache --cache-location=node_modules/.cache/eslint", + "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=330 --cache --cache-location=node_modules/.cache/eslint", "lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh", "lint-watch": "npx eslint-watch --watch --changed", "shellcheck": "./scripts/shellCheck.sh", From c6a5e157f30dedc9c9930c3cf2b1961a83618667 Mon Sep 17 00:00:00 2001 From: Gandalf Date: Tue, 12 Aug 2025 14:48:33 +0530 Subject: [PATCH 3/3] Update src/libs/HttpUtils.ts --- src/libs/HttpUtils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/HttpUtils.ts b/src/libs/HttpUtils.ts index c4b3f5fd4dc7..90ce7c50cedd 100644 --- a/src/libs/HttpUtils.ts +++ b/src/libs/HttpUtils.ts @@ -22,7 +22,7 @@ const ABORT_COMMANDS = { type AbortCommand = keyof typeof ABORT_COMMANDS; -// We have used `connectWithoutView` here because OnyxUpdates is not connected to any UI +// We have used `connectWithoutView` here because HttpUtils is not connected to any UI component Onyx.connectWithoutView({ key: ONYXKEYS.NETWORK, callback: (network) => {