From 54e7494c7b141a865b815afe53ca01fb0114fd87 Mon Sep 17 00:00:00 2001 From: DylanDylann Date: Fri, 7 Nov 2025 18:46:03 +0700 Subject: [PATCH] fix app perf --- src/libs/PersonalDetailsUtils.ts | 23 +++++++++++++++++++---- src/libs/ReportUtils.ts | 23 +++++++++++++++++++---- 2 files changed, 38 insertions(+), 8 deletions(-) diff --git a/src/libs/PersonalDetailsUtils.ts b/src/libs/PersonalDetailsUtils.ts index a74597f286fb..328ef1798e2c 100644 --- a/src/libs/PersonalDetailsUtils.ts +++ b/src/libs/PersonalDetailsUtils.ts @@ -36,6 +36,23 @@ Onyx.connect({ }, }); +let hiddenTranslation = ''; +let youTranslation = ''; + +Onyx.connect({ + key: ONYXKEYS.ARE_TRANSLATIONS_LOADING, + initWithStoredValues: false, + callback: (value) => { + if (value ?? true) { + return; + } + // eslint-disable-next-line @typescript-eslint/no-deprecated + hiddenTranslation = translateLocal('common.hidden'); + // eslint-disable-next-line @typescript-eslint/no-deprecated + youTranslation = translateLocal('common.you').toLowerCase(); + }, +}); + const regexMergedAccount = new RegExp(CONST.REGEX.MERGED_ACCOUNT_PREFIX); function getDisplayNameOrDefault( @@ -43,8 +60,7 @@ function getDisplayNameOrDefault( defaultValue = '', shouldFallbackToHidden = true, shouldAddCurrentUserPostfix = false, - // eslint-disable-next-line @typescript-eslint/no-deprecated - youAfterTranslation = translateLocal('common.you').toLowerCase(), + youAfterTranslation = youTranslation, ): string { let displayName = passedPersonalDetails?.displayName ?? ''; @@ -84,8 +100,7 @@ function getDisplayNameOrDefault( if (login) { return login; } - // eslint-disable-next-line @typescript-eslint/no-deprecated - return shouldFallbackToHidden ? translateLocal('common.hidden') : ''; + return shouldFallbackToHidden ? hiddenTranslation : ''; } /** diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts index ee1857a546ad..1f17a07c0beb 100644 --- a/src/libs/ReportUtils.ts +++ b/src/libs/ReportUtils.ts @@ -1171,6 +1171,23 @@ Onyx.connect({ }, }); +let hiddenTranslation = ''; +let unavailableTranslation = ''; + +Onyx.connect({ + key: ONYXKEYS.ARE_TRANSLATIONS_LOADING, + initWithStoredValues: false, + callback: (value) => { + if (value ?? true) { + return; + } + // eslint-disable-next-line @typescript-eslint/no-deprecated + hiddenTranslation = translateLocal('common.hidden'); + // eslint-disable-next-line @typescript-eslint/no-deprecated + unavailableTranslation = translateLocal('workspace.common.unavailable'); + }, +}); + function getCurrentUserAvatar(): AvatarSource | undefined { return currentUserPersonalDetails?.avatar; } @@ -1314,8 +1331,7 @@ function getPolicyType(report: OnyxInputOrEntry, policies: OnyxCollectio * Get the policy name from a given report */ function getPolicyName({report, returnEmptyIfNotFound = false, policy, policies, reports}: GetPolicyNameParams): string { - // eslint-disable-next-line @typescript-eslint/no-deprecated - const noPolicyFound: string = returnEmptyIfNotFound ? '' : translateLocal('workspace.common.unavailable'); + const noPolicyFound = returnEmptyIfNotFound ? '' : unavailableTranslation; const parentReport = report ? getRootParentReport({report, reports}) : undefined; if (isEmptyObject(report) || (isEmptyObject(policies) && isEmptyObject(allPolicies) && !report?.policyName && !parentReport?.policyName)) { @@ -3100,8 +3116,7 @@ function getDisplayNameForParticipant({ } // If the user's personal details (first name) should be hidden, make sure we return "hidden" instead of the short name - // eslint-disable-next-line @typescript-eslint/no-deprecated - if (shouldFallbackToHidden && longName === translateLocal('common.hidden')) { + if (shouldFallbackToHidden && longName === hiddenTranslation) { return longName; }