From ac2b5effdf2fcb11bc29d5cd45e6b00d1ecea629 Mon Sep 17 00:00:00 2001 From: Linh Date: Fri, 21 Nov 2025 16:55:53 +0700 Subject: [PATCH 1/2] fix: workspace chat display unread after create empty report --- src/libs/actions/Report.ts | 4 ++-- tests/actions/ReportTest.ts | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/libs/actions/Report.ts b/src/libs/actions/Report.ts index 12484f9a5d6e..971300748348 100644 --- a/src/libs/actions/Report.ts +++ b/src/libs/actions/Report.ts @@ -2873,7 +2873,7 @@ function buildNewReportOptimisticData( { onyxMethod: Onyx.METHOD.MERGE, key: `${ONYXKEYS.COLLECTION.REPORT}${parentReport?.reportID}`, - value: {lastVisibleActionCreated: optimisticReportPreview.created, iouReportID: reportID, ...outstandingChildRequest}, + value: {iouReportID: reportID, ...outstandingChildRequest}, }, { onyxMethod: Onyx.METHOD.MERGE, @@ -2919,7 +2919,7 @@ function buildNewReportOptimisticData( { onyxMethod: Onyx.METHOD.MERGE, key: `${ONYXKEYS.COLLECTION.REPORT}${parentReport?.reportID}`, - value: {lastVisibleActionCreated: parentReport?.lastVisibleActionCreated, hasOutstandingChildRequest: parentReport?.hasOutstandingChildRequest}, + value: {hasOutstandingChildRequest: parentReport?.hasOutstandingChildRequest}, }, ]; diff --git a/tests/actions/ReportTest.ts b/tests/actions/ReportTest.ts index 2e5b744f181d..47ce8a63cd1e 100644 --- a/tests/actions/ReportTest.ts +++ b/tests/actions/ReportTest.ts @@ -1780,7 +1780,6 @@ describe('actions/Report', () => { // assert correctness of crucial onyx data expect(createdReport?.reportID).toBe(reportID); expect(parentPolicyExpenseChat?.lastVisibleActionCreated).toBe(reportPreviewAction?.created); - expect(parentPolicyExpenseChat?.hasOutstandingChildRequest).toBe(true); expect(createdReport?.total).toBe(0); expect(createdReport?.parentReportActionID).toBe(reportPreviewAction?.reportActionID); From af23ebaee7c910dc0657e6a4a1cdaa5ffa5286a3 Mon Sep 17 00:00:00 2001 From: Linh Date: Fri, 21 Nov 2025 17:41:22 +0700 Subject: [PATCH 2/2] chore: remove test --- tests/actions/ReportTest.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/actions/ReportTest.ts b/tests/actions/ReportTest.ts index 47ce8a63cd1e..9c9e8e34e44f 100644 --- a/tests/actions/ReportTest.ts +++ b/tests/actions/ReportTest.ts @@ -1779,7 +1779,7 @@ describe('actions/Report', () => { const parentPolicyExpenseChat = reports?.[`${ONYXKEYS.COLLECTION.REPORT}${parentReport?.reportID}`]; // assert correctness of crucial onyx data expect(createdReport?.reportID).toBe(reportID); - expect(parentPolicyExpenseChat?.lastVisibleActionCreated).toBe(reportPreviewAction?.created); + expect(parentPolicyExpenseChat?.hasOutstandingChildRequest).toBe(true); expect(createdReport?.total).toBe(0); expect(createdReport?.parentReportActionID).toBe(reportPreviewAction?.reportActionID);