diff --git a/package.json b/package.json index a364ad0ed6ec..3ca0e185d64e 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ "test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand", "perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure", "typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc", - "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=128 --cache --cache-location=node_modules/.cache/eslint --concurrency=auto", + "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=145 --cache --cache-location=node_modules/.cache/eslint --concurrency=auto", "lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh", "check-lazy-loading": "ts-node scripts/checkLazyLoading.ts", "lint-watch": "npx eslint-watch --watch --changed", diff --git a/scripts/lintChanged.sh b/scripts/lintChanged.sh index 3a3ff8e4c667..6ca48b7669d0 100755 --- a/scripts/lintChanged.sh +++ b/scripts/lintChanged.sh @@ -36,7 +36,7 @@ fi # Run eslint on the changed files if [[ -n "$GIT_DIFF_OUTPUT" ]] ; then # shellcheck disable=SC2086 # For multiple files in variable - eslint --concurrency=auto --max-warnings=133 --config ./eslint.changed.config.mjs $GIT_DIFF_OUTPUT + eslint --concurrency=auto --max-warnings=145 --config ./eslint.changed.config.mjs $GIT_DIFF_OUTPUT else info "No TypeScript files changed" fi diff --git a/src/components/AccountSwitcher.tsx b/src/components/AccountSwitcher.tsx index 7495ee4a5925..a22fb01ca7d5 100644 --- a/src/components/AccountSwitcher.tsx +++ b/src/components/AccountSwitcher.tsx @@ -3,7 +3,6 @@ import {Str} from 'expensify-common'; import React, {useRef, useState} from 'react'; import {View} from 'react-native'; import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails'; -import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset'; import useLocalize from '@hooks/useLocalize'; import useNetwork from '@hooks/useNetwork'; import useOnyx from '@hooks/useOnyx'; @@ -24,7 +23,6 @@ import type {Errors} from '@src/types/onyx/OnyxCommon'; import Avatar from './Avatar'; import ConfirmModal from './ConfirmModal'; import Icon from './Icon'; -// eslint-disable-next-line no-restricted-imports import * as Expensicons from './Icon/Expensicons'; import type {PopoverMenuItem} from './PopoverMenu'; import PopoverMenu from './PopoverMenu'; @@ -57,7 +55,6 @@ function AccountSwitcher({isScreenFocused}: AccountSwitcherProps) { const buttonRef = useRef(null); const {windowHeight} = useWindowDimensions(); - const expensifyIcons = useMemoizedLazyExpensifyIcons(['CaretUpDown'] as const); const [shouldShowDelegatorMenu, setShouldShowDelegatorMenu] = useState(false); const [shouldShowOfflineModal, setShouldShowOfflineModal] = useState(false); @@ -222,7 +219,7 @@ function AccountSwitcher({isScreenFocused}: AccountSwitcherProps) { diff --git a/src/components/AnimatedCollapsible/index.tsx b/src/components/AnimatedCollapsible/index.tsx index 5ccad9e54a31..83290d66ac5e 100644 --- a/src/components/AnimatedCollapsible/index.tsx +++ b/src/components/AnimatedCollapsible/index.tsx @@ -5,9 +5,9 @@ import type {StyleProp, ViewStyle} from 'react-native'; import Animated, {useAnimatedStyle, useDerivedValue, useSharedValue, withTiming} from 'react-native-reanimated'; import {scheduleOnRN} from 'react-native-worklets'; import Icon from '@components/Icon'; +import * as Expensicons from '@components/Icon/Expensicons'; import {easing} from '@components/Modal/ReanimatedModal/utils'; import {PressableWithFeedback} from '@components/Pressable'; -import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset'; import useTheme from '@hooks/useTheme'; import useThemeStyles from '@hooks/useThemeStyles'; import CONST from '@src/CONST'; @@ -69,7 +69,6 @@ function AnimatedCollapsible({ const contentHeight = useSharedValue(0); const hasExpanded = useSharedValue(isExpanded); const [isRendered, setIsRendered] = React.useState(isExpanded); - const expensifyIcons = useMemoizedLazyExpensifyIcons(['DownArrow', 'UpArrow'] as const); useEffect(() => { hasExpanded.set(isExpanded); @@ -122,7 +121,7 @@ function AnimatedCollapsible({ > {({hovered}) => ( @@ -108,7 +107,7 @@ function ApprovalWorkflowSection({approvalWorkflow, onPress}: ApprovalWorkflowSe ))} diff --git a/src/components/Attachments/AttachmentCarousel/CarouselButtons.tsx b/src/components/Attachments/AttachmentCarousel/CarouselButtons.tsx index 05ba9019d1cb..04fd1163af44 100644 --- a/src/components/Attachments/AttachmentCarousel/CarouselButtons.tsx +++ b/src/components/Attachments/AttachmentCarousel/CarouselButtons.tsx @@ -2,8 +2,8 @@ import React from 'react'; import {View} from 'react-native'; import type {Attachment} from '@components/Attachments/types'; import Button from '@components/Button'; +import * as Expensicons from '@components/Icon/Expensicons'; import Tooltip from '@components/Tooltip'; -import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset'; import useLocalize from '@hooks/useLocalize'; import useResponsiveLayout from '@hooks/useResponsiveLayout'; import useTheme from '@hooks/useTheme'; @@ -39,7 +39,6 @@ function CarouselButtons({page, attachments, shouldShowArrows, onBack, onForward const isForwardDisabled = page === attachments.length - 1; const {translate} = useLocalize(); const {shouldUseNarrowLayout} = useResponsiveLayout(); - const expensifyIcons = useMemoizedLazyExpensifyIcons(['ArrowRight', 'BackArrow'] as const); return shouldShowArrows ? ( <> @@ -49,7 +48,7 @@ function CarouselButtons({page, attachments, shouldShowArrows, onBack, onForward