From 7c15d72e7148607d045b22f36c5f1bea824a4a5b Mon Sep 17 00:00:00 2001 From: Mark Toman Date: Wed, 9 Feb 2022 01:34:17 +0100 Subject: [PATCH 1/2] Fix rate rounding --- .../workspace/reimburse/WorkspaceReimburseNoVBAView.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/pages/workspace/reimburse/WorkspaceReimburseNoVBAView.js b/src/pages/workspace/reimburse/WorkspaceReimburseNoVBAView.js index 6812fdaad943..282acc89e06f 100644 --- a/src/pages/workspace/reimburse/WorkspaceReimburseNoVBAView.js +++ b/src/pages/workspace/reimburse/WorkspaceReimburseNoVBAView.js @@ -83,9 +83,13 @@ class WorkspaceReimburseNoVBAView extends React.Component { getRateDisplayValue(value) { const numValue = parseFloat(value); - return !Number.isNaN(numValue) - ? numValue.toFixed(2).toString() - : ''; + if (Number.isNaN(numValue)) { + return ''; + } + const fraction = numValue.toString().split('.')[1]; + return !fraction || fraction.length < 2 + ? numValue.toFixed(2) + : numValue.toString(); } setRate(value) { From 7aba2363e3fedc6428b27559ae37254481c93ec7 Mon Sep 17 00:00:00 2001 From: Mark Toman Date: Thu, 10 Feb 2022 16:50:21 +0100 Subject: [PATCH 2/2] Read and write rate as cents --- src/pages/workspace/reimburse/WorkspaceReimburseNoVBAView.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/workspace/reimburse/WorkspaceReimburseNoVBAView.js b/src/pages/workspace/reimburse/WorkspaceReimburseNoVBAView.js index 282acc89e06f..6fd05caef55a 100644 --- a/src/pages/workspace/reimburse/WorkspaceReimburseNoVBAView.js +++ b/src/pages/workspace/reimburse/WorkspaceReimburseNoVBAView.js @@ -64,7 +64,7 @@ class WorkspaceReimburseNoVBAView extends React.Component { Policy.setCustomUnitRate(this.props.policyID, this.state.unitID, { customUnitRateID: this.state.rateID, name: this.state.rateName, - rate: value, + rate: value * 100, }, null); }, 3000, {leading: false, trailing: true}); @@ -76,7 +76,7 @@ class WorkspaceReimburseNoVBAView extends React.Component { unitValue: lodashGet(props, 'policy.customUnit.value', 'mi'), rateID: lodashGet(props, 'policy.customUnit.rate.id', ''), rateName: lodashGet(props, 'policy.customUnit.rate.name', ''), - rateValue: this.getRateDisplayValue(lodashGet(props, 'policy.customUnit.rate.value', '')), + rateValue: this.getRateDisplayValue(lodashGet(props, 'policy.customUnit.rate.value', 0) / 100), rateCurrency: lodashGet(props, 'policy.customUnit.rate.currency', ''), }; }