From d5e8befdffc19d21f42aed8aa3b2013b1e431f24 Mon Sep 17 00:00:00 2001 From: Vit Horacek Date: Wed, 14 Jan 2026 21:13:30 +0100 Subject: [PATCH 1/3] Fix default report name handling in WorkspaceReportsPage --- src/pages/workspace/reports/WorkspaceReportsPage.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/workspace/reports/WorkspaceReportsPage.tsx b/src/pages/workspace/reports/WorkspaceReportsPage.tsx index 09e9e0452f19..4edb84ee98fb 100644 --- a/src/pages/workspace/reports/WorkspaceReportsPage.tsx +++ b/src/pages/workspace/reports/WorkspaceReportsPage.tsx @@ -231,7 +231,7 @@ function WorkspaceReportFieldsPage({ > Navigation.navigate(ROUTES.REPORTS_DEFAULT_TITLE.getRoute(policyID))} @@ -243,7 +243,7 @@ function WorkspaceReportFieldsPage({ switchAccessibilityLabel={translate('workspace.reports.preventMembersFromChangingCustomNamesTitle')} wrapperStyle={[styles.sectionMenuItemTopDescription, styles.mt3]} titleStyle={toggleTitleStyle} - isActive={!policy?.fieldList?.[CONST.POLICY.FIELDS.FIELD_LIST_TITLE]?.deletable} + isActive={policy?.fieldList?.[CONST.POLICY.FIELDS.FIELD_LIST_TITLE]?.deletable === false} onToggle={(isEnabled) => { if (isEnabled && !isControlPolicy(policy)) { Navigation.navigate( From fdc4e298943223fbba2a7b25d825820cbc46ab3c Mon Sep 17 00:00:00 2001 From: Vit Horacek Date: Wed, 14 Jan 2026 21:26:16 +0100 Subject: [PATCH 2/3] Improve handling of deletable field in policy actions and fix default report name fallback in WorkspaceReportsPage --- src/libs/actions/Policy/Policy.ts | 4 +++- src/pages/workspace/reports/WorkspaceReportsPage.tsx | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libs/actions/Policy/Policy.ts b/src/libs/actions/Policy/Policy.ts index 5ca81bb3be10..641c791c24fa 100644 --- a/src/libs/actions/Policy/Policy.ts +++ b/src/libs/actions/Policy/Policy.ts @@ -5704,7 +5704,9 @@ function setPolicyPreventMemberCreatedTitle(policyID: string, enforced: boolean) // eslint-disable-next-line @typescript-eslint/no-deprecated const policy = getPolicy(policyID); - if (!enforced === policy?.fieldList?.[CONST.POLICY.FIELDS.FIELD_LIST_TITLE].deletable) { + // When fieldList is empty, deletable is undefined. We treat undefined as true (not enforced) to match OldDot's fallback behavior. + const currentDeletable = policy?.fieldList?.[CONST.POLICY.FIELDS.FIELD_LIST_TITLE]?.deletable ?? true; + if (!enforced === currentDeletable) { return; } diff --git a/src/pages/workspace/reports/WorkspaceReportsPage.tsx b/src/pages/workspace/reports/WorkspaceReportsPage.tsx index 4edb84ee98fb..660e9deba8a6 100644 --- a/src/pages/workspace/reports/WorkspaceReportsPage.tsx +++ b/src/pages/workspace/reports/WorkspaceReportsPage.tsx @@ -231,7 +231,7 @@ function WorkspaceReportFieldsPage({ > Navigation.navigate(ROUTES.REPORTS_DEFAULT_TITLE.getRoute(policyID))} From 7e734fc202eae9d3155775e40dcc20ca2700bd63 Mon Sep 17 00:00:00 2001 From: Vit Horacek Date: Wed, 14 Jan 2026 23:31:50 +0100 Subject: [PATCH 3/3] Prevent crash --- src/pages/workspace/reports/WorkspaceReportsPage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/workspace/reports/WorkspaceReportsPage.tsx b/src/pages/workspace/reports/WorkspaceReportsPage.tsx index 660e9deba8a6..3273496a9fdc 100644 --- a/src/pages/workspace/reports/WorkspaceReportsPage.tsx +++ b/src/pages/workspace/reports/WorkspaceReportsPage.tsx @@ -111,7 +111,7 @@ function WorkspaceReportFieldsPage({ fieldID: reportField.fieldID, pendingAction: reportField.pendingAction, isDisabled: reportField.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE, - rightLabel: Str.recapitalize(translate(getReportFieldTypeTranslationKey(reportField.type))), + rightLabel: Str.recapitalize(translate(getReportFieldTypeTranslationKey(reportField.type ?? CONST.REPORT_FIELD_TYPES.TEXT))), })); }, [filteredPolicyFieldList, policy, translate, localeCompare]);