From e8a47172be7f0e833583fc6f1edadccbdd0bca64 Mon Sep 17 00:00:00 2001 From: situchan Date: Tue, 14 Apr 2026 03:26:05 +0600 Subject: [PATCH 1/2] fix task complete sound is heard when disabling category --- src/libs/actions/Task.ts | 7 +++++-- src/libs/actions/Workflow.ts | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/libs/actions/Task.ts b/src/libs/actions/Task.ts index 96226fe62507..e703f975691a 100644 --- a/src/libs/actions/Task.ts +++ b/src/libs/actions/Task.ts @@ -507,6 +507,7 @@ function completeTask( parentReportAction: OnyxEntry | undefined, delegateEmail: string | undefined, reportIDFromAction?: string, + shouldPlaySound = true, ): OnyxData { const taskReportID = taskReport?.reportID ?? reportIDFromAction; @@ -523,7 +524,9 @@ function completeTask( delegateEmail, ); - playSound(SOUNDS.SUCCESS); + if (shouldPlaySound) { + playSound(SOUNDS.SUCCESS); + } API.write(WRITE_COMMANDS.COMPLETE_TASK, parameters, {optimisticData, successData, failureData}); return {optimisticData, successData, failureData}; } @@ -1448,7 +1451,7 @@ function getFinishOnboardingTaskOnyxData( if (taskReport) { if (taskReport.stateNum !== CONST.REPORT.STATE_NUM.APPROVED || taskReport.statusNum !== CONST.REPORT.STATUS_NUM.APPROVED) { // Will be refactored in next PR; full restructure tracked in https://github.com/Expensify/App/issues/66417 - return completeTask(taskReport, taskParentReport?.hasOutstandingChildTask ?? false, hasOutstandingChildTask, parentReportAction, undefined); + return completeTask(taskReport, taskParentReport?.hasOutstandingChildTask ?? false, hasOutstandingChildTask, parentReportAction, undefined, undefined, false); } } } diff --git a/src/libs/actions/Workflow.ts b/src/libs/actions/Workflow.ts index a650c7332648..4830316c05d6 100644 --- a/src/libs/actions/Workflow.ts +++ b/src/libs/actions/Workflow.ts @@ -93,7 +93,7 @@ function createApprovalWorkflow({approvalWorkflow, policy, addExpenseApprovalsTa (addExpenseApprovalsTaskReport.stateNum !== CONST.REPORT.STATE_NUM.APPROVED || addExpenseApprovalsTaskReport.statusNum !== CONST.REPORT.STATUS_NUM.APPROVED) ) { // Will be refactored in next PR; full restructure tracked in https://github.com/Expensify/App/issues/66417 - completeTask(addExpenseApprovalsTaskReport, false, false, undefined, undefined); + completeTask(addExpenseApprovalsTaskReport, false, false, undefined, undefined, undefined, false); } } From 89587c07a63a97da4cf69be6808b89c204aa1a30 Mon Sep 17 00:00:00 2001 From: situchan Date: Wed, 15 Apr 2026 23:40:33 +0600 Subject: [PATCH 2/2] fix test --- tests/actions/WorkflowTest.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/actions/WorkflowTest.ts b/tests/actions/WorkflowTest.ts index 5fff4468b2eb..310e42492f71 100644 --- a/tests/actions/WorkflowTest.ts +++ b/tests/actions/WorkflowTest.ts @@ -308,7 +308,7 @@ describe('actions/Workflow', () => { await mockFetch.resume(); await waitForBatchedUpdates(); - expect(completeTaskMock).toHaveBeenCalledWith(addExpenseApprovalsTaskReport, false, false, undefined, undefined); + expect(completeTaskMock).toHaveBeenCalledWith(addExpenseApprovalsTaskReport, false, false, undefined, undefined, undefined, false); }); it('should not auto-complete the task if it is already approved', async () => {