From 5fd005cfe740fb1f1c811a126fd6c4fd6ddd7cd8 Mon Sep 17 00:00:00 2001 From: "daledah (via MelvinBot)" Date: Mon, 11 May 2026 14:40:57 +0000 Subject: [PATCH] Use hasAccountingConnections instead of getValidConnectedIntegration for category button visibility The "Add category" button in the expense category picker was using getValidConnectedIntegration which excludes unverified (failed) connections, while the Categories settings page uses hasAccountingConnections which detects any connection regardless of sync status. This aligns both checks so the button is consistently hidden when an accounting connection exists but has failed. Co-authored-by: daledah --- src/pages/iou/request/step/IOURequestStepCategory.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/iou/request/step/IOURequestStepCategory.tsx b/src/pages/iou/request/step/IOURequestStepCategory.tsx index 1cd0b66237c1..340d8d945cfe 100644 --- a/src/pages/iou/request/step/IOURequestStepCategory.tsx +++ b/src/pages/iou/request/step/IOURequestStepCategory.tsx @@ -30,7 +30,7 @@ import {isCategoryMissing} from '@libs/CategoryUtils'; import getNonEmptyStringOnyxID from '@libs/getNonEmptyStringOnyxID'; import Navigation from '@libs/Navigation/Navigation'; import {hasEnabledOptions} from '@libs/OptionsListUtils'; -import {getValidConnectedIntegration, isPolicyAdmin} from '@libs/PolicyUtils'; +import {hasAccountingConnections, isPolicyAdmin} from '@libs/PolicyUtils'; import {getTransactionDetails, isGroupPolicy, isReportInGroupPolicy} from '@libs/ReportUtils'; import type {SkeletonSpanReasonAttributes} from '@libs/telemetry/useSkeletonSpan'; import {getRequestType} from '@libs/TransactionUtils'; @@ -92,7 +92,7 @@ function IOURequestStepCategory({ const categoryForDisplay = isCategoryMissing(transactionCategory) ? '' : transactionCategory; - const canCreateCategoryInSitu = isPolicyAdmin(policy) && !getValidConnectedIntegration(policy) && !!policy?.areCategoriesEnabled; + const canCreateCategoryInSitu = isPolicyAdmin(policy) && !hasAccountingConnections(policy) && !!policy?.areCategoriesEnabled; const createCategoryMenuItems = canCreateCategoryInSitu ? [