From 3fcf01d5cbfb30729452814a246977538ab30d01 Mon Sep 17 00:00:00 2001 From: Andrew Gable Date: Tue, 19 May 2026 13:59:18 -0600 Subject: [PATCH 1/2] Improve Help deploy failure observability --- .github/workflows/deployExpensifyHelp.yml | 25 ++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/.github/workflows/deployExpensifyHelp.yml b/.github/workflows/deployExpensifyHelp.yml index 4c4e17528bec..71cee7438462 100644 --- a/.github/workflows/deployExpensifyHelp.yml +++ b/.github/workflows/deployExpensifyHelp.yml @@ -31,7 +31,6 @@ jobs: env: IS_PR_FROM_FORK: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork }} runs-on: blacksmith-2vcpu-ubuntu-2404 - continue-on-error: true steps: - name: Checkout # v6 @@ -133,3 +132,27 @@ jobs: GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }} COMMENT_PREFIX: A preview of your ExpensifyHelp changes have been deployed to COMMENT_BODY: ${{ steps.preview_comment.outputs.BODY }} + + notifyFailure: + name: Warn deployers if Expensify Help deploy failed + runs-on: blacksmith-2vcpu-ubuntu-2404 + needs: build + if: ${{ failure() && github.ref == 'refs/heads/main' && github.event_name != 'pull_request' }} + steps: + - name: Warn deployers if Expensify Help deploy failed + # v3 + uses: 8398a7/action-slack@1750b5085f3ec60384090fb7c52965ef822e869e + with: + status: custom + custom_payload: | + { + channel: '#deployer', + attachments: [{ + color: "#DB4545", + pretext: ``, + text: `Expensify Help production failed.`, + }] + } + env: + GITHUB_TOKEN: ${{ github.token }} + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK }} From 9cdc09b26ec2ce6338e5a21f2618636b67b6f9a6 Mon Sep 17 00:00:00 2001 From: Andrew Gable Date: Tue, 19 May 2026 14:33:19 -0600 Subject: [PATCH 2/2] Improve message --- .github/workflows/deployExpensifyHelp.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/deployExpensifyHelp.yml b/.github/workflows/deployExpensifyHelp.yml index 71cee7438462..946240478bc9 100644 --- a/.github/workflows/deployExpensifyHelp.yml +++ b/.github/workflows/deployExpensifyHelp.yml @@ -150,7 +150,7 @@ jobs: attachments: [{ color: "#DB4545", pretext: ``, - text: `Expensify Help production failed.`, + text: `Expensify Help failed. Please fix it!`, }] } env: