Skip to content

Commit 44b641c

Browse files
JeremyWuuuuuzazzaz
authored andcommitted
fix(project):fix gc.sh generating wrong format templates
fix(utils):fix utils linting issues
1 parent bde4eb1 commit 44b641c

File tree

10 files changed

+28
-31
lines changed

10 files changed

+28
-31
lines changed

packages/utils/isDef.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
export function isDef(val) {
1+
export function isDef(val: unknown): boolean {
22
return val !== undefined && val !== null
33
}
4-
export function isKorean(text: string) {
4+
export function isKorean(text: string): boolean {
55
const reg = /([(\uAC00-\uD7AF)|(\u3130-\u318F)])+/gi
66
return reg.test(text)
77
}

packages/utils/menu/menu-item.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {eventKeys, triggerEvent} from '../aria'
1+
import { eventKeys, triggerEvent } from '../aria'
22
import SubMenu from './submenu'
33

44

packages/utils/menu/submenu.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import {eventKeys, triggerEvent } from '../aria'
1+
import { eventKeys, triggerEvent } from '../aria'
22
import MenuItem from './menu-item'
33

44
class SubMenu {

packages/utils/merge.ts

Lines changed: 0 additions & 7 deletions
This file was deleted.

packages/utils/resize-event.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import ResizeObserver from 'resize-observer-polyfill'
22
import isServer from './isServer'
33

44
type ResizableElement = CustomizedHTMLElement<{
5-
__resizeListeners__: Array<Function>;
5+
__resizeListeners__: Array<(...args: unknown[]) => unknown>;
66
__ro__: ResizeObserver;
77
}>;
88

@@ -22,8 +22,8 @@ const resizeHandler = function(entries: ResizeObserverEntry[]) {
2222
/* istanbul ignore next */
2323
export const addResizeListener = function(
2424
element: ResizableElement,
25-
fn: Function,
26-
) {
25+
fn: (...args: unknown[]) => unknown,
26+
): void {
2727
if (isServer) return
2828
if (!element.__resizeListeners__) {
2929
element.__resizeListeners__ = []
@@ -36,8 +36,8 @@ export const addResizeListener = function(
3636
/* istanbul ignore next */
3737
export const removeResizeListener = function(
3838
element: ResizableElement,
39-
fn: Function,
40-
) {
39+
fn: (...args: unknown[]) => unknown,
40+
): void {
4141
if (!element || !element.__resizeListeners__) return
4242
element.__resizeListeners__.splice(
4343
element.__resizeListeners__.indexOf(fn),

packages/utils/scroll-into-view.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import isServer from './isServer'
33
export default function scrollIntoView(
44
container: HTMLElement,
55
selected: HTMLElement,
6-
) {
6+
): void {
77
if (isServer) return
88

99
if (!selected) {

packages/utils/scrollbar-width.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import isServer from './isServer'
22

33
let scrollBarWidth: number
44

5-
export default function() {
5+
export default function(): number {
66
if (isServer) return 0
77
if (scrollBarWidth !== undefined) return scrollBarWidth
88

packages/utils/tests/aria.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import Utils, {triggerEvent, isFocusable, attemptFocus} from '../aria'
1+
import { triggerEvent, isFocusable } from '../aria'
22

33
const CE = (tag: string) => document.createElement(tag)
44

packages/utils/util.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ export {
132132
capitalize,
133133
}
134134

135-
export function rafThrottle(fn: (args: Record<string, unknown>) => unknown): (...args: any[]) => any {
135+
export function rafThrottle(fn: (args: Record<string, unknown>) => unknown): (...args: unknown[]) => unknown {
136136
let locked = false
137137
return function(...args) {
138138
if (locked) return
@@ -145,3 +145,5 @@ export function rafThrottle(fn: (args: Record<string, unknown>) => unknown): (..
145145
}
146146

147147
export const objToArray = castArray
148+
149+
export { isVNode } from 'vue'

scripts/gc.sh

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,18 @@ mkdir -p "$DIRNAME/__tests__"
3333
cat > $DIRNAME/src/index.vue <<EOF
3434
<template>
3535
<div>
36-
<slot/>
36+
<slot></slot>
3737
</div>
3838
</template>
3939
<script lang='ts'>
40-
export default {
41-
NAME: 'El${NAME}',
42-
props: {
43-
},
44-
setup(props,ctx) { }
45-
};
40+
import { defineComponent } from 'vue'
41+
export default defineComponent({
42+
name: 'El${NAME}',
43+
props: { },
44+
setup(props) {
45+
// init here
46+
},
47+
})
4648
</script>
4749
<style scoped>
4850
</style>
@@ -51,7 +53,7 @@ EOF
5153
cat <<EOF >"$DIRNAME/index.ts"
5254
import { App } from 'vue'
5355
import ${NAME} from './src/index.vue'
54-
export default (app: App) => {
56+
export default (app: App): void => {
5557
app.component(${NAME}.name, ${NAME})
5658
}
5759
EOF
@@ -72,7 +74,7 @@ cat > $DIRNAME/package.json <<EOF
7274
EOF
7375

7476
cat > $DIRNAME/__tests__/$INPUT_NAME.spec.ts <<EOF
75-
import {mount} from '@vue/test-utils'
77+
import { mount } from '@vue/test-utils'
7678
import $NAME from '../src/index.vue'
7779
7880
const AXIOM = 'Rem is the best girl'
@@ -81,7 +83,7 @@ describe('$NAME.vue', () => {
8183
test('render test', () => {
8284
const wrapper = mount($NAME, {
8385
slots: {
84-
default: AXIOM
86+
default: AXIOM,
8587
},
8688
})
8789
expect(wrapper.text()).toEqual(AXIOM)
@@ -93,7 +95,7 @@ cat <<EOF >"$DIRNAME/doc/index.stories.ts"
9395
import El${NAME} from '../index'
9496
9597
export default {
96-
title: "${NAME}"
98+
title: '${NAME}',
9799
}
98100
99101
EOF

0 commit comments

Comments
 (0)