Add option for key release

Author: Fabi019

app/src/main/java/dev/fabik/bluetoothhid/Scanner.kt

@@ -527,20 +527,22 @@ private fun BoxScope.BarcodeValue(currentBarcode: String?) {
 private fun VolumeKeyHandler(onPress: (Int) -> Boolean) {
     val context = LocalContext.current
     val sendWithVolume by context.getPreferenceState(PreferenceStore.SEND_WITH_VOLUME)
+    val triggerOnRelease by context.getPreferenceState(PreferenceStore.VOLUME_ON_RELEASE)
 
     if (sendWithVolume == true) {
         val view = LocalView.current
 
         DisposableEffect(context) {
             val keyEventDispatcher = ViewCompat.OnUnhandledKeyEventListenerCompat { _, event ->
                 if (event.keyCode == KeyEvent.KEYCODE_VOLUME_UP || event.keyCode == KeyEvent.KEYCODE_VOLUME_DOWN) {
-                    if (event.action == KeyEvent.ACTION_UP)
-                        onPress(event.keyCode)
-                    else
-                        true
-                } else {
-                    false
+                    if (event.repeatCount == 0
+                        && (event.action == KeyEvent.ACTION_UP && triggerOnRelease == true
+                                || event.action == KeyEvent.ACTION_DOWN && triggerOnRelease == false)
+                    )
+                        return@OnUnhandledKeyEventListenerCompat onPress(event.keyCode)
+                    return@OnUnhandledKeyEventListenerCompat true
                 }
+                false
             }
 
             ViewCompat.addOnUnhandledKeyEventListener(view, keyEventDispatcher)

app/src/main/java/dev/fabik/bluetoothhid/ui/VolumeKeyOptions.kt

@@ -28,10 +28,13 @@ import androidx.compose.runtime.saveable.rememberSaveable
 import androidx.compose.runtime.setValue
 import androidx.compose.ui.Alignment
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.res.stringArrayResource
+import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.semantics.semantics
 import androidx.compose.ui.semantics.stateDescription
 import androidx.compose.ui.tooling.preview.Preview
 import androidx.compose.ui.unit.dp
+import dev.fabik.bluetoothhid.R
 import dev.fabik.bluetoothhid.utils.PreferenceStore
 import dev.fabik.bluetoothhid.utils.rememberPreference
 import dev.fabik.bluetoothhid.utils.rememberPreferenceNull
@@ -45,8 +48,8 @@ fun VolumeKeyOptionsModal() {
     var showSheet by rememberSaveable { mutableStateOf(false) }
 
     ButtonPreference(
-        title = "Use volume keys",
-        desc = "Specify action when pressing volume up/down",
+        title = stringResource(R.string.send_with_volume_keys),
+        desc = stringResource(R.string.send_vol_keys_desc),
         icon = Icons.AutoMirrored.Filled.VolumeMute,
         onClick = { showSheet = true },
         extra = {
@@ -90,36 +93,33 @@ fun VolumeKeysOptionsContent() {
             .padding(horizontal = 16.dp)
     ) {
         Text(
-            "Volume keys",
+            stringResource(R.string.send_with_volume_keys),
             style = MaterialTheme.typography.titleLarge,
         )
 
-        val actions = arrayOf(
-            "Nothing",
-            "Send value",
-            "Clear value",
-            "Run OCR",
-            "Open manual input",
-            "Toggle flash",
-            "Toggle zoom",
-            "Trigger focus"
-        )
+        val actions = stringArrayResource(R.array.volume_keys_actions)
 
         AdvancedEnumSelectionOption(
-            "Volume up",
+            stringResource(R.string.volume_up),
             actions,
             PreferenceStore.VOLUME_ACTION_UP
         )
 
         AdvancedEnumSelectionOption(
-            "Volume down",
-            actions,
-            PreferenceStore.VOLUME_ACTION_DOWN
+            text = stringResource(R.string.volume_down),
+            values = actions,
+            preference = PreferenceStore.VOLUME_ACTION_DOWN
         )
 
-        AdvancedSliderOption("Zoom level (%)", 0f to 100f, PreferenceStore.VOLUME_ZOOM_LEVEL)
-
-        //AdvancedToggleOption("Trigger on key release")
+        AdvancedSliderOption(
+            stringResource(R.string.zoom_level),
+            0f to 100f,
+            PreferenceStore.VOLUME_ZOOM_LEVEL
+        )
+        AdvancedToggleOption(
+            stringResource(R.string.trigger_on_key_release),
+            PreferenceStore.VOLUME_ON_RELEASE
+        )
 
         Spacer(Modifier.height(12.dp))
     }

app/src/main/java/dev/fabik/bluetoothhid/utils/PreferenceStore.kt

@@ -189,6 +189,7 @@ open class PreferenceStore {
             intPreferencesKey("vol_action_up") enumDefaultsTo VolumeKeyAction::fromIndex
         val VOLUME_ACTION_DOWN =
             intPreferencesKey("vol_action_down") enumDefaultsTo VolumeKeyAction::fromIndex
+        val VOLUME_ON_RELEASE = booleanPreferencesKey("vol_on_release") defaultsTo false
         val VOLUME_ZOOM_LEVEL = floatPreferencesKey("vol_action_zoom") defaultsTo 1f
         val SEND_DELAY = floatPreferencesKey("send_delay") defaultsTo 10f
         val KEYBOARD_LAYOUT = intPreferencesKey("keyboard_layout").enumDefaultsTo(KeyboardLayout::fromIndex)