Merge pull request teng-lin#204 from chkp-roniz/feat/edge-browser-login

feat(cli): add --browser flag to login for Microsoft Edge SSO support

Author: teng-lin

README.md

@@ -118,6 +118,8 @@ pip install git+https://github.com/teng-lin/notebooklm-py@main
 ```bash
 # 1. Authenticate (opens browser)
 notebooklm login
+# Or use Microsoft Edge (for orgs that require Edge for SSO)
+# notebooklm login --browser msedge
 
 # 2. Create a notebook and add sources
 notebooklm create "My Research"

docs/cli-reference.md

@@ -38,7 +38,7 @@ See [Configuration](configuration.md) for details on environment variables and C
 
 | Command | Description | Example |
 |---------|-------------|---------|
-| `login` | Authenticate via browser | `notebooklm login` |
+| `login` | Authenticate via browser | `notebooklm login` / `notebooklm login --browser msedge` |
 | `use <id>` | Set active notebook | `notebooklm use abc123` |
 | `status` | Show current context | `notebooklm status` |
 | `status --paths` | Show configuration paths | `notebooklm status --paths` |
@@ -232,11 +232,24 @@ These CLI capabilities are not available in NotebookLM's web interface:
 Authenticate with Google NotebookLM via browser.
 
 ```bash
-notebooklm login
+notebooklm login [OPTIONS]
 ```
 
 Opens a Chromium browser with a persistent profile. Log in to your Google account, then press Enter in the terminal to save the session.
 
+**Options:**
+- `--storage PATH` - Where to save storage_state.json (default: `$NOTEBOOKLM_HOME/storage_state.json`)
+- `--browser [chromium|msedge]` - Browser to use for login (default: `chromium`). Use `msedge` for Microsoft Edge.
+
+**Examples:**
+```bash
+# Default (Chromium)
+notebooklm login
+
+# Use Microsoft Edge (for orgs that require Edge for SSO)
+notebooklm login --browser msedge
+```
+
 ### Session: `use`
 
 Set the active notebook for subsequent commands.

src/notebooklm/cli/session.py

@@ -160,12 +160,20 @@ def register_session_commands(cli):
         default=None,
         help="Where to save storage_state.json (default: $NOTEBOOKLM_HOME/storage_state.json)",
     )
-    def login(storage):
+    @click.option(
+        "--browser",
+        type=click.Choice(["chromium", "msedge"], case_sensitive=False),
+        default="chromium",
+        help="Browser to use for login (default: chromium). Use 'msedge' for Microsoft Edge.",
+    )
+    def login(storage, browser):
         """Log in to NotebookLM via browser.
 
         Opens a browser window for Google login. After logging in,
         press ENTER in the terminal to save authentication.
 
+        Use --browser msedge if your organization requires Microsoft Edge for SSO.
+
         Note: Cannot be used when NOTEBOOKLM_AUTH_JSON is set (use file-based
         auth or unset the env var first).
         """
@@ -184,36 +192,56 @@ def login(storage):
         try:
             from playwright.sync_api import sync_playwright
         except ImportError:
-            console.print(
-                "[red]Playwright not installed. Run:[/red]\n"
-                "  pip install notebooklm[browser]\n"
-                "  playwright install chromium"
-            )
+            if browser == "msedge":
+                install_hint = "  pip install notebooklm[browser]"
+            else:
+                install_hint = "  pip install notebooklm[browser]\n  playwright install chromium"
+            console.print(f"[red]Playwright not installed. Run:[/red]\n{install_hint}")
             raise SystemExit(1) from None
 
-        # Pre-flight check: verify Chromium browser is installed
-        _ensure_chromium_installed()
+        # Pre-flight check: verify Chromium browser is installed (skip for Edge)
+        if browser == "chromium":
+            _ensure_chromium_installed()
 
         storage_path = Path(storage) if storage else get_storage_path()
         browser_profile = get_browser_profile_dir()
         storage_path.parent.mkdir(parents=True, exist_ok=True, mode=0o700)
         browser_profile.mkdir(parents=True, exist_ok=True, mode=0o700)
 
-        console.print("[yellow]Opening browser for Google login...[/yellow]")
+        browser_label = "Microsoft Edge" if browser == "msedge" else "Chromium"
+        console.print(f"[yellow]Opening {browser_label} for Google login...[/yellow]")
         console.print(f"[dim]Using persistent profile: {browser_profile}[/dim]")
 
         # Use context manager to restore ProactorEventLoop for Playwright on Windows
         # (fixes #89: NotImplementedError on Windows Python 3.12)
         with _windows_playwright_event_loop(), sync_playwright() as p:
-            context = p.chromium.launch_persistent_context(
-                user_data_dir=str(browser_profile),
-                headless=False,
-                args=[
+            launch_kwargs: dict[str, Any] = {
+                "user_data_dir": str(browser_profile),
+                "headless": False,
+                "args": [
                     "--disable-blink-features=AutomationControlled",
                     "--password-store=basic",  # Avoid macOS keychain encryption for headless compatibility
                 ],
-                ignore_default_args=["--enable-automation"],
-            )
+                "ignore_default_args": ["--enable-automation"],
+            }
+            if browser == "msedge":
+                launch_kwargs["channel"] = "msedge"
+
+            try:
+                context = p.chromium.launch_persistent_context(**launch_kwargs)
+            except Exception as e:
+                if browser == "msedge" and (
+                    "executable doesn't exist" in str(e).lower()
+                    or "no such file" in str(e).lower()
+                    or "failed to launch" in str(e).lower()
+                ):
+                    console.print(
+                        "[red]Microsoft Edge not found.[/red]\n"
+                        "Install from: https://www.microsoft.com/edge\n"
+                        "Or use the default Chromium browser: notebooklm login"
+                    )
+                    raise SystemExit(1) from None
+                raise
 
             page = context.pages[0] if context.pages else context.new_page()
             page.goto(NOTEBOOKLM_URL)

tests/unit/cli/test_session.py

@@ -83,6 +83,97 @@ def test_login_blocked_when_notebooklm_auth_json_set(self, runner, monkeypatch):
         assert result.exit_code == 1
         assert "Cannot run 'login' when NOTEBOOKLM_AUTH_JSON is set" in result.output
 
+    def test_login_help_shows_browser_option(self, runner):
+        """Test login --help shows --browser option with chromium/msedge choices."""
+        result = runner.invoke(cli, ["login", "--help"])
+
+        assert result.exit_code == 0
+        assert "--browser" in result.output
+        assert "chromium" in result.output
+        assert "msedge" in result.output
+
+    def test_login_rejects_invalid_browser(self, runner):
+        """Test login rejects invalid --browser values."""
+        result = runner.invoke(cli, ["login", "--browser", "firefox"])
+
+        assert result.exit_code != 0
+
+    @pytest.fixture
+    def mock_login_browser(self, tmp_path):
+        """Mock Playwright browser launch for login --browser tests.
+
+        Yields (mock_ensure, mock_launch) for assertions on chromium install
+        check and launch_persistent_context kwargs.
+        """
+        with (
+            patch("notebooklm.cli.session._ensure_chromium_installed") as mock_ensure,
+            patch("playwright.sync_api.sync_playwright") as mock_pw,
+            patch(
+                "notebooklm.cli.session.get_storage_path", return_value=tmp_path / "storage.json"
+            ),
+            patch(
+                "notebooklm.cli.session.get_browser_profile_dir",
+                return_value=tmp_path / "profile",
+            ),
+            patch("notebooklm.cli.session._sync_server_language_to_config"),
+            patch("builtins.input", return_value=""),
+        ):
+            mock_context = MagicMock()
+            mock_page = MagicMock()
+            mock_page.url = "https://notebooklm.google.com/"
+            mock_context.pages = [mock_page]
+            mock_launch = (
+                mock_pw.return_value.__enter__.return_value.chromium.launch_persistent_context
+            )
+            mock_launch.return_value = mock_context
+
+            yield mock_ensure, mock_launch
+
+    def test_login_msedge_skips_chromium_install(self, runner, mock_login_browser):
+        """Test --browser msedge skips _ensure_chromium_installed."""
+        mock_ensure, _ = mock_login_browser
+        runner.invoke(cli, ["login", "--browser", "msedge"])
+        mock_ensure.assert_not_called()
+
+    def test_login_msedge_passes_channel_param(self, runner, mock_login_browser):
+        """Test --browser msedge passes channel='msedge' to launch_persistent_context."""
+        _, mock_launch = mock_login_browser
+        runner.invoke(cli, ["login", "--browser", "msedge"])
+        assert mock_launch.call_args[1].get("channel") == "msedge"
+
+    def test_login_chromium_default_no_channel(self, runner, mock_login_browser):
+        """Test default chromium calls _ensure_chromium_installed and has no channel."""
+        mock_ensure, mock_launch = mock_login_browser
+        runner.invoke(cli, ["login", "--browser", "chromium"])
+        mock_ensure.assert_called_once()
+        assert "channel" not in mock_launch.call_args[1]
+
+    def test_login_msedge_not_installed_shows_helpful_error(self, runner, tmp_path):
+        """Test --browser msedge shows helpful error when Edge is not installed."""
+        with (
+            patch("notebooklm.cli.session._ensure_chromium_installed"),
+            patch("playwright.sync_api.sync_playwright") as mock_pw,
+            patch(
+                "notebooklm.cli.session.get_storage_path", return_value=tmp_path / "storage.json"
+            ),
+            patch(
+                "notebooklm.cli.session.get_browser_profile_dir",
+                return_value=tmp_path / "profile",
+            ),
+        ):
+            mock_launch = (
+                mock_pw.return_value.__enter__.return_value.chromium.launch_persistent_context
+            )
+            mock_launch.side_effect = Exception(
+                "Executable doesn't exist at /ms-edge\nFailed to launch"
+            )
+
+            result = runner.invoke(cli, ["login", "--browser", "msedge"])
+
+        assert result.exit_code == 1
+        assert "Microsoft Edge not found" in result.output
+        assert "microsoft.com/edge" in result.output
+
 
 # =============================================================================
 # USE COMMAND TESTS