-
Notifications
You must be signed in to change notification settings - Fork 9
feat: anon piece selection and retrieval #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c9bdfa4
96c82c6
81a38b1
072a096
1fcee60
4527d29
a797c15
54cc487
fcfe569
fb45bd0
92c40a8
d4f7d80
ab3748a
beffac7
f26744b
5cee3ee
95a2dff
cff3171
3c2a698
d82222f
527283f
8dfb3ca
b8a2621
70af7c0
b003d78
21b4f2d
a4f0b38
1a32373
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,3 +21,5 @@ coverage/ | |
| # per-package lockfiles are stray | ||
| apps/*/pnpm-lock.yaml | ||
| !pnpm-lock.yaml | ||
|
|
||
| .tool-versions | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -56,7 +56,16 @@ export const configValidationSchema = Joi.object({ | |||||
| USE_ONLY_APPROVED_PROVIDERS: Joi.boolean().default(true), | ||||||
| DEALBOT_DATASET_VERSION: Joi.string().optional(), | ||||||
| MIN_NUM_DATASETS_FOR_CHECKS: Joi.number().integer().min(1).default(1), | ||||||
| // Two subgraph endpoints coexist intentionally to limit blast radius while we | ||||||
| // migrate off the upstream pdp-explorer subgraph: | ||||||
| // - PDP_SUBGRAPH_ENDPOINT drives the established overdue-periods / data | ||||||
| // retention path against the existing pdp-explorer subgraph. | ||||||
| // - SUBGRAPH_ENDPOINT drives only the new anonymous-retrieval candidate | ||||||
| // piece query against the dealbot-owned subgraph. | ||||||
| // Once the dealbot-owned subgraph has soaked in production we can drop | ||||||
| // PDP_SUBGRAPH_ENDPOINT and route everything through SUBGRAPH_ENDPOINT. | ||||||
| PDP_SUBGRAPH_ENDPOINT: Joi.string().uri().optional().allow(""), | ||||||
| SUBGRAPH_ENDPOINT: Joi.string().uri().optional().allow(""), | ||||||
|
|
||||||
| // Scheduling | ||||||
| PROVIDERS_REFRESH_INTERVAL_SECONDS: Joi.number().default(4 * 3600), | ||||||
|
|
@@ -80,6 +89,7 @@ export const configValidationSchema = Joi.object({ | |||||
| DEALS_PER_SP_PER_HOUR: Joi.number().min(0.001).max(20).default(4), | ||||||
| DATASET_CREATIONS_PER_SP_PER_HOUR: Joi.number().min(0.001).max(20).default(1), | ||||||
| RETRIEVALS_PER_SP_PER_HOUR: Joi.number().min(0.001).max(20).default(2), | ||||||
| RETRIEVALS_ANON_PER_SP_PER_HOUR: Joi.number().min(0.001).max(20).optional(), | ||||||
|
||||||
| RETRIEVALS_ANON_PER_SP_PER_HOUR: Joi.number().min(0.001).max(20).optional(), | |
| RETRIEVALS_ANON_PER_SP_PER_HOUR: Joi.number().min(0.001).max(20).empty("").optional(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is data that can be easily derived. Also is it
(ttlb-ttfb)/bytesor simplyttlb/bytes?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's
http response size/total time of the HTTP requestThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it could easily be derived, I agree