Improve invalid iOS regex error message (#479)

Author: bootstraponline

test_runner/src/main/kotlin/ftl/args/IosArgs.kt

@@ -159,15 +159,19 @@ ${listToString(testTargets)}
     }
 }
 
-fun filterTests(validTestMethods: List<String>, testTargets: List<String>): List<String> {
-    if (testTargets.isEmpty()) {
+fun filterTests(validTestMethods: List<String>, testTargetsRgx: List<String>): List<String> {
+    if (testTargetsRgx.isEmpty()) {
         return validTestMethods
     }
 
     return validTestMethods.filter { test ->
-        testTargets.forEach { target ->
-            if (test.matches(target.toRegex())) {
-                return@filter true
+        testTargetsRgx.forEach { target ->
+            try {
+                if (test.matches(target.toRegex())) {
+                    return@filter true
+                }
+            } catch (e: Exception) {
+                throw IllegalArgumentException("Invalid regex: $target", e)
             }
         }
 

test_runner/src/test/kotlin/ftl/args/IosArgsTest.kt

@@ -626,6 +626,11 @@ IosArgs
         "ClassFourTest/testFour"
     )
 
+    @Test(expected = IllegalArgumentException::class)
+    fun `invalid regex filter throws custom exception`() {
+        filterTests(listOf("test"), testTargetsRgx = listOf("*."))
+    }
+
     @Test
     fun filterTests_emptyFilter() {
         val tests = getValidTestsSample()