When no locale found exit code: 1

Author: adamfilipow92

test_runner/src/main/kotlin/ftl/environment/LocalesDescription.kt

@@ -1,6 +1,7 @@
 package ftl.environment
 
 import com.google.api.services.testing.model.Locale
+import ftl.util.FlankGeneralError
 
 fun List<Locale>.getLocaleDescription(localeId: String) = findLocales(localeId)?.prepareDescription().orErrorMessage(localeId).plus("\n")
 
@@ -23,4 +24,4 @@ private fun StringBuilder.appendTagsToList(locale: Locale) = apply {
     locale.tags.filterNotNull().forEach { tag -> appendln("- $tag") }
 }.trim().toString()
 
-private fun String?.orErrorMessage(locale: String) = this ?: "ERROR: '$locale' is not a valid locale"
+private fun String?.orErrorMessage(locale: String) = this ?: throw FlankGeneralError("ERROR: '$locale' is not a valid locale")

test_runner/src/test/kotlin/ftl/cli/firebase/test/android/configuration/AndroidLocalesDescribeCommandTest.kt

@@ -1,6 +1,7 @@
 package ftl.cli.firebase.test.android.configuration
 
 import ftl.android.AndroidCatalog
+import ftl.test.util.TestHelper.getThrowable
 import ftl.util.FlankConfigurationError
 import io.mockk.mockkObject
 import io.mockk.verify
@@ -29,9 +30,7 @@ class AndroidLocalesDescribeCommandTest {
 
     @Test
     fun `should return error message if locale not exists`() {
-        systemOutRule.clearLog()
-        CommandLine(AndroidLocalesDescribeCommand()).execute("test")
-        val result = systemOutRule.log.trim()
-        assertEquals("ERROR: 'test' is not a valid locale", result)
+        val exception = getThrowable { CommandLine(AndroidLocalesDescribeCommand()).execute("test") }
+        assertEquals("ERROR: 'test' is not a valid locale", exception.message)
     }
 }

test_runner/src/test/kotlin/ftl/cli/firebase/test/ios/configuration/IosLocalesDescribeCommandTest.kt

@@ -2,6 +2,7 @@ package ftl.cli.firebase.test.ios.configuration
 
 import ftl.ios.IosCatalog
 import ftl.test.util.TestHelper
+import ftl.test.util.TestHelper.getThrowable
 import ftl.util.FlankConfigurationError
 import io.mockk.mockkObject
 import io.mockk.verify
@@ -32,9 +33,8 @@ class IosLocalesDescribeCommandTest {
 
     @Test
     fun `should return error message if locale not exists`() {
-        systemOutRule.clearLog()
-        CommandLine(IosLocalesDescribeCommand()).execute("test", "--config=$simpleFlankPath")
-        val result = systemOutRule.log.trim()
+        val exception = getThrowable { CommandLine(IosLocalesDescribeCommand()).execute("test", "--config=$simpleFlankPath") }
+        val result = exception.message
         assertEquals("ERROR: 'test' is not a valid locale", result)
     }
 }