From 95eacaef0e601168911a0ec67cde2415d33390b3 Mon Sep 17 00:00:00 2001
From: Karsten Dambekalns <karsten@dambekalns.de>
Date: Thu, 26 Jun 2025 11:39:45 +0200
Subject: [PATCH] BUGFIX: Drop FilterByReferenceOperation

This is broken (references are no longer properties) and can be solved
way easier, e.g.

    collection = ${q(node).backReferenceNodes('tags')}

instead of

    collection = ${q(site).find('[instanceof Acme.Com:Document.Post]').filterByReference('tags', node).get()}
---
 .../FilterByReferenceOperation.php            | 73 -------------------
 README.md                                     |  4 -
 2 files changed, 77 deletions(-)
 delete mode 100644 Classes/Fusion/Eel/FlowQueryOperations/FilterByReferenceOperation.php

diff --git a/Classes/Fusion/Eel/FlowQueryOperations/FilterByReferenceOperation.php b/Classes/Fusion/Eel/FlowQueryOperations/FilterByReferenceOperation.php
deleted file mode 100644
index 1719a71..0000000
--- a/Classes/Fusion/Eel/FlowQueryOperations/FilterByReferenceOperation.php
+++ /dev/null
@@ -1,73 +0,0 @@
-<?php
-
-namespace Flowpack\Listable\Fusion\Eel\FlowQueryOperations;
-
-/*                                                                        *
- * This script belongs to the Flow package "Flowpack.Listable".           *
- *                                                                        */
-
-use Neos\ContentRepository\Core\Projection\ContentGraph\Node;
-use Neos\Eel\FlowQuery\FlowQuery;
-use Neos\Eel\FlowQuery\FlowQueryException;
-use Neos\Eel\FlowQuery\Operations\AbstractOperation;
-use Neos\Flow\Annotations as Flow;
-
-/**
- * FlowQuery operation to filter by properties of type reference or references
- */
-class FilterByReferenceOperation extends AbstractOperation
-{
-    /**
-     * {@inheritdoc}
-     */
-    protected static $shortName = 'filterByReference';
-
-    /**
-     * {@inheritdoc}
-     */
-    protected static $priority = 100;
-
-    /**
-     * {@inheritdoc}
-     *
-     * We can only handle CR Nodes.
-     */
-    public function canEvaluate($context)
-    {
-        return (!isset($context[0]) || ($context[0] instanceof Node));
-    }
-
-    /**
-     * {@inheritdoc}
-     *
-     * @param array $arguments The arguments for this operation.
-     *                         First argument is property to filter by, must be of reference of references type.
-     *                         Second is object to filter by, must be Node.
-     *
-     * @return void
-     * @throws FlowQueryException
-     */
-    public function evaluate(FlowQuery $flowQuery, array $arguments)
-    {
-        if (empty($arguments[0])) {
-            throw new FlowQueryException('filterByReference() needs reference property name by which nodes should be filtered', 1332492263);
-        }
-        if (empty($arguments[1])) {
-            throw new FlowQueryException('filterByReference() needs node reference by which nodes should be filtered', 1332493263);
-        }
-
-        /** @var Node $nodeReference */
-        list($filterByPropertyPath, $nodeReference) = $arguments;
-
-        $filteredNodes = [];
-        foreach ($flowQuery->getContext() as $node) {
-            /** @var Node $node */
-            $propertyValue = $node->getProperty($filterByPropertyPath);
-            if ($nodeReference == $propertyValue || (is_array($propertyValue) && in_array($nodeReference, $propertyValue, false))) {
-                $filteredNodes[] = $node;
-            }
-        }
-
-        $flowQuery->setContext($filteredNodes);
-    }
-}
diff --git a/README.md b/README.md
index 1820e40..79bfd64 100644
--- a/README.md
+++ b/README.md
@@ -147,10 +147,6 @@ Configuration options:
 
 Filter nodes by properties of type date.
 
-## filterByReference
-
-Filter nodes by properties of type reference or references.
-
 ## sortRecursiveByIndex
 
 Sort nodes by their position in the node tree. Please use with care, as this can become a very expensive operation, if you operate on bigger subtrees.