From 919910d0f450b5866089d377cdc65c800ced1253 Mon Sep 17 00:00:00 2001 From: CelularBat <105959781+CelularBat@users.noreply.github.com> Date: Mon, 20 Nov 2023 07:36:01 +0000 Subject: [PATCH 1/7] Update ft-profile-selector.css Fixed for low res, fixed linter complains --- .../components/ft-profile-selector/ft-profile-selector.css | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/renderer/components/ft-profile-selector/ft-profile-selector.css b/src/renderer/components/ft-profile-selector/ft-profile-selector.css index 94ee6e91d376e..c5ae6b11ec861 100644 --- a/src/renderer/components/ft-profile-selector/ft-profile-selector.css +++ b/src/renderer/components/ft-profile-selector/ft-profile-selector.css @@ -27,7 +27,7 @@ inset-block-start: 60px; inset-inline-end: 10px; min-inline-size: 250px; - block-size: 400px; + block-size: auto; padding: 5px; background-color: var(--card-bg-color); box-shadow: 0 0 4px var(--scrollbar-color-hover); @@ -35,8 +35,10 @@ .profileWrapper { margin-block-start: 60px; - block-size: 340px; + block-size: auto; overflow-y: auto; + max-block-size: calc(90vh - 100px); + min-block-size: 340px; } .profile { From 1090b859d1d1f41c3a67389dac6fac28a77d7834 Mon Sep 17 00:00:00 2001 From: CelularBat <105959781+CelularBat@users.noreply.github.com> Date: Wed, 22 Nov 2023 02:49:58 +0000 Subject: [PATCH 2/7] Update comment to max-block-size --- .../components/ft-profile-selector/ft-profile-selector.css | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/renderer/components/ft-profile-selector/ft-profile-selector.css b/src/renderer/components/ft-profile-selector/ft-profile-selector.css index c5ae6b11ec861..b0ec457f8796f 100644 --- a/src/renderer/components/ft-profile-selector/ft-profile-selector.css +++ b/src/renderer/components/ft-profile-selector/ft-profile-selector.css @@ -35,9 +35,11 @@ .profileWrapper { margin-block-start: 60px; - block-size: auto; + block-size: auto; overflow-y: auto; - max-block-size: calc(90vh - 100px); + /*max-block-size: 90% of window size - 100 px. It's scaled to be 340px on 800x600 resolution. + Offset of 100px is to compensate for the fixed size of elements aboce the list, which takes more screen space on lower resolutions */ + max-block-size: calc(90vh - 100px); min-block-size: 340px; } From 28777ad4dc516d36eadcba5371687b513fe2053a Mon Sep 17 00:00:00 2001 From: CelularBat <105959781+CelularBat@users.noreply.github.com> Date: Wed, 22 Nov 2023 02:50:51 +0000 Subject: [PATCH 3/7] comment to max-block-size fixed typo --- .../components/ft-profile-selector/ft-profile-selector.css | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/renderer/components/ft-profile-selector/ft-profile-selector.css b/src/renderer/components/ft-profile-selector/ft-profile-selector.css index b0ec457f8796f..c64330571c494 100644 --- a/src/renderer/components/ft-profile-selector/ft-profile-selector.css +++ b/src/renderer/components/ft-profile-selector/ft-profile-selector.css @@ -37,8 +37,8 @@ margin-block-start: 60px; block-size: auto; overflow-y: auto; - /*max-block-size: 90% of window size - 100 px. It's scaled to be 340px on 800x600 resolution. - Offset of 100px is to compensate for the fixed size of elements aboce the list, which takes more screen space on lower resolutions */ + /* max-block-size: 90% of window size - 100 px. It's scaled to be 340px on 800x600 resolution. + Offset of 100px is to compensate for the fixed size of elements above the list, which takes more screen space on lower resolutions */ max-block-size: calc(90vh - 100px); min-block-size: 340px; } From 75af05def6916972140fc28d8f2ebcd9937f34b9 Mon Sep 17 00:00:00 2001 From: CelularBat <105959781+CelularBat@users.noreply.github.com> Date: Wed, 22 Nov 2023 04:28:15 +0000 Subject: [PATCH 4/7] Update ft-profile-selector.css adjust for screen with horizontal navbar (mobile) --- .../ft-profile-selector/ft-profile-selector.css | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/renderer/components/ft-profile-selector/ft-profile-selector.css b/src/renderer/components/ft-profile-selector/ft-profile-selector.css index c64330571c494..8d58df4d87995 100644 --- a/src/renderer/components/ft-profile-selector/ft-profile-selector.css +++ b/src/renderer/components/ft-profile-selector/ft-profile-selector.css @@ -37,12 +37,20 @@ margin-block-start: 60px; block-size: auto; overflow-y: auto; - /* max-block-size: 90% of window size - 100 px. It's scaled to be 340px on 800x600 resolution. + /* profile list max height: 90% of window size - 100 px. It's scaled to be 340px on 800x600 resolution. Offset of 100px is to compensate for the fixed size of elements above the list, which takes more screen space on lower resolutions */ max-block-size: calc(90vh - 100px); min-block-size: 340px; } +/* Navbar changes position to horizontal with this media rule. +Height adjust for profile list so it won't cover navbar. */ +@media only screen and (max-width: 680px){ + .profileWrapper { + max-block-size: calc(95vh - 180px); + } +} + .profile { cursor: pointer; block-size: 50px; From 49b2213c3f4f73dad475d45ae5c318dadce81b07 Mon Sep 17 00:00:00 2001 From: CelularBat <105959781+CelularBat@users.noreply.github.com> Date: Wed, 22 Nov 2023 05:58:02 +0000 Subject: [PATCH 5/7] Update src/renderer/components/ft-profile-selector/ft-profile-selector.css Co-authored-by: PikachuEXE --- .../components/ft-profile-selector/ft-profile-selector.css | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/renderer/components/ft-profile-selector/ft-profile-selector.css b/src/renderer/components/ft-profile-selector/ft-profile-selector.css index 8d58df4d87995..863cf3b00eb7b 100644 --- a/src/renderer/components/ft-profile-selector/ft-profile-selector.css +++ b/src/renderer/components/ft-profile-selector/ft-profile-selector.css @@ -46,9 +46,9 @@ /* Navbar changes position to horizontal with this media rule. Height adjust for profile list so it won't cover navbar. */ @media only screen and (max-width: 680px){ - .profileWrapper { - max-block-size: calc(95vh - 180px); - } + .profileWrapper { + max-block-size: calc(95vh - 180px); + } } .profile { From 7b23737835fb76b92ec9ca7ce18fcab1645a6350 Mon Sep 17 00:00:00 2001 From: CelularBat <105959781+CelularBat@users.noreply.github.com> Date: Wed, 22 Nov 2023 05:58:18 +0000 Subject: [PATCH 6/7] Update src/renderer/components/ft-profile-selector/ft-profile-selector.css Co-authored-by: PikachuEXE --- .../components/ft-profile-selector/ft-profile-selector.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/renderer/components/ft-profile-selector/ft-profile-selector.css b/src/renderer/components/ft-profile-selector/ft-profile-selector.css index 863cf3b00eb7b..a48ef87c268ba 100644 --- a/src/renderer/components/ft-profile-selector/ft-profile-selector.css +++ b/src/renderer/components/ft-profile-selector/ft-profile-selector.css @@ -35,7 +35,7 @@ .profileWrapper { margin-block-start: 60px; - block-size: auto; + block-size: auto; overflow-y: auto; /* profile list max height: 90% of window size - 100 px. It's scaled to be 340px on 800x600 resolution. Offset of 100px is to compensate for the fixed size of elements above the list, which takes more screen space on lower resolutions */ From 33b1bed752992c883238dd716d2558b59f55efba Mon Sep 17 00:00:00 2001 From: CelularBat <105959781+CelularBat@users.noreply.github.com> Date: Wed, 22 Nov 2023 05:59:10 +0000 Subject: [PATCH 7/7] Update src/renderer/components/ft-profile-selector/ft-profile-selector.css Co-authored-by: PikachuEXE --- .../components/ft-profile-selector/ft-profile-selector.css | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/renderer/components/ft-profile-selector/ft-profile-selector.css b/src/renderer/components/ft-profile-selector/ft-profile-selector.css index a48ef87c268ba..49d63c22a0b71 100644 --- a/src/renderer/components/ft-profile-selector/ft-profile-selector.css +++ b/src/renderer/components/ft-profile-selector/ft-profile-selector.css @@ -37,8 +37,10 @@ margin-block-start: 60px; block-size: auto; overflow-y: auto; - /* profile list max height: 90% of window size - 100 px. It's scaled to be 340px on 800x600 resolution. - Offset of 100px is to compensate for the fixed size of elements above the list, which takes more screen space on lower resolutions */ + /* + profile list max height: 90% of window size - 100 px. It's scaled to be 340px on 800x600 resolution. + Offset of 100px is to compensate for the fixed size of elements above the list, which takes more screen space on lower resolutions + */ max-block-size: calc(90vh - 100px); min-block-size: 340px; }