Fixed stutter once a wipe transition to the Main Menu completes.#2315
Merged
ninjamuffin99 merged 1 commit intoFunkinCrew:developfrom May 9, 2024
ImCodist:bugfix/main-menu-camera-stutter
Merged
Fixed stutter once a wipe transition to the Main Menu completes.#2315ninjamuffin99 merged 1 commit intoFunkinCrew:developfrom ImCodist:bugfix/main-menu-camera-stutter
ninjamuffin99 merged 1 commit intoFunkinCrew:developfrom
ImCodist:bugfix/main-menu-camera-stutter
Conversation
Member
|
haha wow nice catch! that bugged me for the longest time lol.... |
8 tasks
Hundrec
added
status: accepted
EliteMasterEric
added
size: tiny
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is this bit of code in the MainMenuState that I assume was supposed to run immediately after changing to the state but instead is run after the transition completes to the state.
This causes the camera to be reset when the transition completes, creating a stutter effect.
I've tested this from multiple scenarios where the state is changed to MainMenuState and nothing seems to break.
i am not sure why this bit of code exists in the first place actually since the camera reset call made just before it seems to work just fine but idk
Footage of this problem happening in game (i apologize for the overlapping music i am too tired to rerecord this clip):
Funkin_JsBtvCm3OO.mp4