[BUGFIX] Prevent constant Vocal Resyncs on Inst-only songs#3861
Merged
EliteMasterEric merged 1 commit intoFunkinCrew:developfrom Jan 17, 2025
Merged
Conversation
github-actions
bot
added
pr: haxe
EliteMasterEric
added
status: pending triage
MidyGamy
pushed a commit
to MidyGamy/Funkin
that referenced
this pull request
Jan 27, 2025
Co-authored-by: Kolo <67389779+JustKolosaki@users.noreply.github.com>
AbnormalPoof
pushed a commit
to AbnormalPoof/Funkin
that referenced
this pull request
Mar 21, 2025
Co-authored-by: Kolo <67389779+JustKolosaki@users.noreply.github.com>
EliteMasterEric
added
size: tiny
dombomb64
pushed a commit
to dombomb64/Funkin
that referenced
this pull request
Jun 3, 2025
Co-authored-by: Kolo <67389779+JustKolosaki@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
3856
Briefly describe the issue(s) fixed.
For some reason when building the voice group in
Song, whether or not the vocal files existed wasn't checked, which this PR aims to fix.Include any relevant screenshots or videos.
Before:
https://github.com/user-attachments/assets/4152f062-c0ad-4855-960a-7971fc05c4b6
After:
https://github.com/user-attachments/assets/810f87e9-78f0-42de-a43d-a94ebd19d5a4
(please ignore there being wrong icons in the footage that's just a side effect of a thing im working on)