Skip to content

[BUGFIX] Fix Chart Editor context menu doing a solitaire#4139

Merged
Hundrec merged 1 commit intoFunkinCrew:dummy/develop-v0.7.3from
Lasercar:chart-editor-content-menu-solitaire-fix
Aug 17, 2025
Merged

[BUGFIX] Fix Chart Editor context menu doing a solitaire#4139
Hundrec merged 1 commit intoFunkinCrew:dummy/develop-v0.7.3from
Lasercar:chart-editor-content-menu-solitaire-fix

Conversation

@Lasercar
Copy link
Contributor

@Lasercar Lasercar commented Feb 14, 2025

Does this PR close any issues? If so, link them below.

Fixes #3338

Briefly describe the issue(s) fixed.

Holding shift and right click while moving your mouse over a note causes additional context menus to appear.

Include any relevant screenshots or videos.

2025-02-14.20-17-55.mp4

@github-actions github-actions bot added status: pending triage Awaiting review. size: large A large pull request with more than 100 changes. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. labels Feb 14, 2025
@Lasercar
Copy link
Contributor Author

Huh, the bot always removes at least one label?

@Hundrec Hundrec added status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue. labels Feb 14, 2025
@Hundrec
Copy link
Member

Hundrec commented Feb 14, 2025

Well that's just plain weird!
Only a small issue though

@amyspark-ng
Copy link
Contributor

i had no idea notes had an extra context menu! that's cooool

@Hundrec
Copy link
Member

Hundrec commented Feb 14, 2025

i had no idea notes had an extra context menu! that's cooool

Yeah, that's a good reminder that we need to write up an F1 guide at some point

@Lasercar Lasercar changed the base branch from develop to main February 22, 2025 01:11
@Lasercar Lasercar changed the base branch from main to develop February 22, 2025 01:11
Copy link
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works!

@Hundrec Hundrec added the topic: chart editor Related to the operation of the Chart Editor. label Mar 9, 2025
Copy link
Member

@AbnormalPoof AbnormalPoof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@EliteMasterEric EliteMasterEric added size: large A large pull request with more than 100 changes. and removed size: large A large pull request with more than 100 changes. labels May 14, 2025
@Lasercar Lasercar changed the title Chart editor context menu solitaire fix [BUGFIX] Chart Editor - Context menu solitaire fix Jun 19, 2025
@Hundrec Hundrec force-pushed the chart-editor-content-menu-solitaire-fix branch from f0ca35a to e603303 Compare August 16, 2025 21:54
@Hundrec Hundrec changed the title [BUGFIX] Chart Editor - Context menu solitaire fix [BUGFIX] Fix Chart Editor context menu doing a solitaire Aug 16, 2025
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Aug 17, 2025
@Hundrec Hundrec added this to the 0.7.4 milestone Aug 17, 2025
@Hundrec Hundrec changed the base branch from develop to dummy/develop-v0.7.3 August 17, 2025 20:02
@Hundrec Hundrec merged commit 73e42be into FunkinCrew:dummy/develop-v0.7.3 Aug 17, 2025
4 checks passed
@Lasercar Lasercar deleted the chart-editor-content-menu-solitaire-fix branch August 18, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.

Development

Successfully merging this pull request may close these issues.

Bug Report: Shift-Right Click Chart Editor context menu does a solitaire when you move your mouse

5 participants