[BUGFIX] Chart Editor - Don't add default difficulty to song metadata#4216
Merged
EliteMasterEric merged 1 commit intoFunkinCrew:developfrom Apr 29, 2025
Conversation
It'll now only add the current difficulty to the metadata if it doesn't exist in it when saved.
github-actions
bot
added
status: pending triage
AbnormalPoof
added
type: minor bug
Member
|
looks good, accepted into v0.6.4. thanks! |
AbnormalPoof
added
status: accepted
Closed
3 tasks
Lasercar
deleted the
chart-editor-don't-add-default-difficulty-to-song-metadata
branch
EliteMasterEric
added
size: medium
Lasercar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Fixes #3111
Briefly describe the issue(s) fixed.
The chart editor would always end up adding the default difficulty to the metadata if it wasn't already there.
Now, not only does it set the selected difficulty when a song is loaded to the first available difficulty, it also only adds a difficulty to the metadata if the one that's selected when the song is saved doesn't exist in it.
Include any relevant screenshots or videos.