Skip to content

[ENHANCEMENT] Sandboxed API Classes#5040

Merged
AbnormalPoof merged 1 commit intoFunkinCrew:developfrom
KoloInDaCrib:gonna-update-my-mod-after-this
Jun 17, 2025
Merged

[ENHANCEMENT] Sandboxed API Classes#5040
AbnormalPoof merged 1 commit intoFunkinCrew:developfrom
KoloInDaCrib:gonna-update-my-mod-after-this

Conversation

@KoloInDaCrib
Copy link
Contributor

@KoloInDaCrib KoloInDaCrib commented May 7, 2025

Linked Issues

Closes #4996
Closes #4997
Closes #4998

Description

Adds sandboxes for following API Classes:

  • NewgroundsClient
  • Medals
  • Leaderboards
  • DiscordClient

The newgrounds class sandboxes only provide getter support, and DiscordClientSandbox provides support for setting the status and shutting it down. Let me know if you think the masses crave for something more.

Screenshots/Videos

Allowed methods for Medals

image

Allowed methods for Leaderboards

image

Allowed methods for NewgroundsClient

image

Allowed methods for DiscordClient

image

@github-actions github-actions bot added size: large A large pull request with more than 100 changes. pr: haxe PR modifies game code. status: pending triage Awaiting review. and removed size: large A large pull request with more than 100 changes. labels May 7, 2025
@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. size: large A large pull request with more than 100 changes. labels May 7, 2025
@Starexify
Copy link
Contributor

Starexify commented May 8, 2025

If you set a presence using the sandboxed discordRPC, will it also update the presence ? Also if possible add a way to update it ourselves since it's hardcoded.

@Keoiki
Copy link
Contributor

Keoiki commented May 8, 2025

If you set a presence using the sandboxed discordRPC, will it also update the presence ? Also if possible add a way to update it ourselves since it's hardcoded.

What? setPresence is how you update the presence, your question makes no sense.

@KoloInDaCrib
Copy link
Contributor Author

KoloInDaCrib commented May 8, 2025

If you set a presence using the sandboxed discordRPC, will it also update the presence ? Also if possible add a way to update it ourselves since it's hardcoded.

setPresence is how you update the presence (it's in the name, you set the presence),
if you mean to fully change the key for the discord presence I'm afraid eric wouldn't allow this

@EliteMasterEric EliteMasterEric added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels May 9, 2025
@EliteMasterEric EliteMasterEric self-assigned this May 9, 2025
@EliteMasterEric EliteMasterEric added size: large A large pull request with more than 100 changes. and removed size: large A large pull request with more than 100 changes. labels May 14, 2025
@EliteMasterEric EliteMasterEric removed their assignment Jun 4, 2025
@Hundrec Hundrec added the status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. label Jun 5, 2025
@Hundrec Hundrec added this to the 0.7.0 milestone Jun 5, 2025
@Hundrec Hundrec removed the status: reviewing internally Under consideration and testing. label Jun 5, 2025
@AbnormalPoof AbnormalPoof merged commit 6575643 into FunkinCrew:develop Jun 17, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: large A large pull request with more than 100 changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. type: enhancement Involves an enhancement or new feature.

Development

Successfully merging this pull request may close these issues.

6 participants