[BUGFIX] Fix the game crashing when hot-reloading with F5#5065
Merged
AbnormalPoof merged 2 commits intoFunkinCrew:developfrom Jun 17, 2025
Merged
Conversation
AbnormalPoof
added
the
type: major bug
github-actions
bot
added
status: pending triage
Member
|
lol |
Hundrec
reviewed
May 11, 2025
…OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO Co-authored-by: Hundrec <hundrecard@gmail.com>
Hundrec
approved these changes
May 11, 2025
Member
Hundrec
left a comment
Hundrec
left a comment
There was a problem hiding this comment.
Fixes Blazin' reloading, probably everything else too!
NotHyper-474
approved these changes
May 11, 2025
Contributor
NotHyper-474
left a comment
NotHyper-474
left a comment
There was a problem hiding this comment.
Yay I was right #4990 (comment)
EliteMasterEric
added
size: tiny
Kade-github
approved these changes
May 28, 2025
AbnormalPoof
added
status: accepted
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes #4990
Description
instancegets set tonullinperformCleanup()when the game hot-reloads, this was caused by #4769.This led to multiple errors from scripts that tried to access
instance, and eventually a crash from line 1882 fromDiscordClient.This PR sets
instanceback tothis, fixing the errors and the aforementioned crash.