Skip to content

[ENHANCEMENT] Chart Editor exit confirmation prompt#5091

Merged
Hundrec merged 1 commit intoFunkinCrew:developfrom
anysad:charter-leave-dialog
Aug 2, 2025
Merged

[ENHANCEMENT] Chart Editor exit confirmation prompt#5091
Hundrec merged 1 commit intoFunkinCrew:developfrom
anysad:charter-leave-dialog

Conversation

@anysad
Copy link
Contributor

@anysad anysad commented May 14, 2025

Description

  • Whenever leaving the chart editor, there always was a problem, that there wasn't a prompt that asks people whether or not they actually want to leave, instead, it would just exit instantly.
  • From what can be seen, people actually want this:

image

Screenshots/Videos

screenshot-2025-05-14-22-40-53

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. labels May 14, 2025
@Hundrec Hundrec added type: enhancement Involves an enhancement or new feature. topic: chart editor Related to the operation of the Chart Editor. labels May 14, 2025
@NotHyper-474
Copy link
Contributor

NotHyper-474 commented May 14, 2025

@anysad
Copy link
Contributor Author

anysad commented May 14, 2025 •
edited
Loading

pretty su... wait what the fuck?

@Hundrec Hundrec self-requested a review May 14, 2025 20:28
@AbnormalPoof AbnormalPoof force-pushed the charter-leave-dialog branch from 588c8e9 to bbb9f8f Compare August 1, 2025 18:06
@Hundrec Hundrec added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Aug 1, 2025
@Hundrec Hundrec removed their request for review August 1, 2025 18:08
@Hundrec Hundrec added this to the 0.7.4 milestone Aug 2, 2025
@Hundrec Hundrec added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: reviewing internally Under consideration and testing. labels Aug 2, 2025
@Hundrec Hundrec merged commit a454bc7 into FunkinCrew:develop Aug 2, 2025
6 checks passed
@Hundrec Hundrec changed the title [ENHANCEMENT] Chart Editor Leave Prompt [ENHANCEMENT] Chart Editor exit confirmation prompt Aug 23, 2025
@Lasercar Lasercar mentioned this pull request Sep 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: chart editor Related to the operation of the Chart Editor. type: enhancement Involves an enhancement or new feature.

Milestone

0.7.4

Development

Successfully merging this pull request may close these issues.

3 participants

@anysad @NotHyper-474 @Hundrec