Skip to content

[BUGFIX] Fix custom parameters for note kinds crashing the game#136

Closed
Lasercar wants to merge 0 commit intoFunkinCrew:mainfrom
Lasercar:chart-editor-note-kind-params-crash-fix
Closed

[BUGFIX] Fix custom parameters for note kinds crashing the game#136
Lasercar wants to merge 0 commit intoFunkinCrew:mainfrom
Lasercar:chart-editor-note-kind-params-crash-fix

Conversation

@Lasercar
Copy link
Contributor

@Lasercar Lasercar commented Mar 3, 2025

Fixes FunkinCrew/Funkin#3292

No idea how the custom note params behave once this fix is applied though, but it's better than it straight up crashing!

@Hundrec Hundrec added topic: chart editor Related to the operation of the Chart Editor. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. labels Mar 3, 2025
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Apr 3, 2025
@EliteMasterEric EliteMasterEric self-assigned this Apr 3, 2025
@EliteMasterEric EliteMasterEric added this to the 0.6.3 milestone Apr 3, 2025
@EliteMasterEric
Copy link
Member

Successfully resolves the listed problem.

@Lasercar Lasercar changed the base branch from main to master April 6, 2025 05:23
@Lasercar Lasercar changed the base branch from master to main April 12, 2025 04:59
@Lasercar Lasercar changed the title Chart editor note kind params crash fix [BUGFIX] Fix custom parameters for note kinds crashing the game Apr 29, 2025
@Lasercar
Copy link
Contributor Author

Oh, uh, should I rebase this to remove those two unnecessary commits....?

@EliteMasterEric
Copy link
Member

image
I can't auto-rebase so please rebase if possible and I'll try to merge.

@Lasercar Lasercar closed this May 1, 2025
@Lasercar Lasercar force-pushed the chart-editor-note-kind-params-crash-fix branch from 41cb095 to f87255d Compare May 1, 2025 06:48
@Lasercar
Copy link
Contributor Author

Lasercar commented May 1, 2025

I can't auto-rebase so please rebase if possible and I'll try to merge.

Ok, done.

Wait, what the heck

@Hundrec
Copy link
Member

Hundrec commented May 1, 2025

Why is this closed now?

@Lasercar
Copy link
Contributor Author

Lasercar commented May 1, 2025

Well, I rebase pulled main, so I guess since the change already exists in it, my commit was removed, basically

Hmm, I could try resetting it to the previous force push commit.

Well that didn't work

Hmm, I got the commit back (as an empty one I guess?), but it didn't fix this PR, sadly. Why is github like this

https://github.com/Lasercar/funkin.assets/commits/chart-editor-note-kind-params-crash-fix/

I'll just delete the branch then.

Next time something like this happens I'll hard reset before the removed commits and then cherry-pick my change back.

@Lasercar
Copy link
Contributor Author

Lasercar commented May 1, 2025

Well anyway, we at least get to see this funny sight for the rest of time...

Screenshot 2025-05-01 171028

@Hundrec
Copy link
Member

Hundrec commented May 1, 2025

True...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: small A small pull request with 10 or fewer changes. status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. topic: chart editor Related to the operation of the Chart Editor. type: major bug Involves a major bug, including crashes, softlocks, or issues blocking progression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash Report: Note Kind Properties crash inside the Chart Editor

3 participants