[BUGFIX] Fix custom parameters for note kinds crashing the game#136
[BUGFIX] Fix custom parameters for note kinds crashing the game#136Lasercar wants to merge 0 commit intoFunkinCrew:mainfrom
Conversation
|
Successfully resolves the listed problem. |
|
Oh, uh, should I rebase this to remove those two unnecessary commits....? |
41cb095 to
f87255d
Compare
Ok, done. Wait, what the heck |
|
Why is this closed now? |
|
Well, I rebase pulled main, so I guess since the change already exists in it, my commit was removed, basically Hmm, I could try resetting it to the previous force push commit. Well that didn't work Hmm, I got the commit back (as an empty one I guess?), but it didn't fix this PR, sadly. Why is github like this https://github.com/Lasercar/funkin.assets/commits/chart-editor-note-kind-params-crash-fix/ I'll just delete the branch then. Next time something like this happens I'll hard reset before the removed commits and then cherry-pick my change back. |
|
True... |


Fixes FunkinCrew/Funkin#3292
No idea how the custom note params behave once this fix is applied though, but it's better than it straight up crashing!