Skip to content

Align freeplay clear percentage#37

Merged
EliteMasterEric merged 1 commit intoFunkinCrew:feature/more-community-bugfixesfrom
Hundrec:align-freeplay-clear-percent
Oct 16, 2024
Merged

Align freeplay clear percentage#37
EliteMasterEric merged 1 commit intoFunkinCrew:feature/more-community-bugfixesfrom
Hundrec:align-freeplay-clear-percent

Conversation

@Hundrec
Copy link
Member

@Hundrec Hundrec commented Jun 25, 2024 •
edited
Loading

Fixes FunkinCrew/Funkin#2907

Adjusts boundaries and standardizes heights in freeplay-clear.xml to fix misaligned numbers.

This is the best alignment I can achieve without editing the font itself.
Perfect alignment can be reached with tiny font edits!

Video demo

clear.percent.align.PR.mp4

@Hundrec
Align freeplay clear percentage
a3f35c5 
Adjusts boundaries and standardizes heights to fix misaligned numbers
@EliteMasterEric EliteMasterEric added status: reviewing internally Under consideration and testing. status: pending triage Awaiting review. type: enhancement Provides an enhancement or new feature. size: small A small pull request with 10 or fewer changes. topic: polish Involves minor polish to the UI or gameplay. and removed status: reviewing internally Under consideration and testing. labels Jul 9, 2024
@EliteMasterEric EliteMasterEric added status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. and removed status: pending triage Awaiting review. labels Sep 26, 2024
@EliteMasterEric EliteMasterEric added this to the 0.5.2 milestone Sep 26, 2024
@Hundrec
Copy link
Member Author

Hundrec commented Oct 12, 2024

Not implemented in 0.5.2

@EliteMasterEric EliteMasterEric modified the milestones: 0.5.2, 0.5.3 Oct 15, 2024
@EliteMasterEric EliteMasterEric changed the base branch from main to feature/more-community-bugfixes October 16, 2024 17:39
@EliteMasterEric EliteMasterEric merged commit 91e8fb8 into FunkinCrew:feature/more-community-bugfixes Oct 16, 2024
@Hundrec Hundrec removed this from the 0.6.0 (Pit Stop 2) milestone Apr 1, 2025
@Hundrec Hundrec added status: rejected PR did not pass review or cannot be approved. and removed status: accepted PR was approved for contribution. If it's not already merged, it may be merged on a private branch. labels Apr 30, 2025
@Hundrec Hundrec mentioned this pull request Apr 30, 2025
Merged
@Hundrec Hundrec added pr: art PR modifies art or animations. topic: freeplay Related to the operation of the Freeplay menu. and removed topic: polish Involves minor polish to the UI or gameplay. labels Apr 30, 2025
@Hundrec Hundrec added size: medium A medium pull request with 100 or fewer changes. and removed size: small A small pull request with 10 or fewer changes. labels May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@anysad anysad anysad approved these changes

@JVNpixels JVNpixels JVNpixels approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: art PR modifies art or animations. size: medium A medium pull request with 100 or fewer changes. status: rejected PR did not pass review or cannot be approved. topic: freeplay Related to the operation of the Freeplay menu. type: enhancement Provides an enhancement or new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug Report: Some numbers in the clear % in freeplay are a bit lower than they should be.

4 participants

@Hundrec @anysad @JVNpixels @EliteMasterEric