From c096ca91fd71067b1c37c8f10116b1fc5e459f7f Mon Sep 17 00:00:00 2001 From: Dongdong Tian Date: Thu, 21 Aug 2025 21:24:53 +0800 Subject: [PATCH] Figure.grdimage: Raise NotImplementedError instead of GMTInvalidInput for -A option --- pygmt/src/grdimage.py | 10 ++-------- pygmt/tests/test_grdimage.py | 6 +++--- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/pygmt/src/grdimage.py b/pygmt/src/grdimage.py index e79ae5af931..240e804a900 100644 --- a/pygmt/src/grdimage.py +++ b/pygmt/src/grdimage.py @@ -6,13 +6,7 @@ from pygmt._typing import PathLike from pygmt.alias import Alias, AliasSystem from pygmt.clib import Session -from pygmt.exceptions import GMTInvalidInput -from pygmt.helpers import ( - build_arg_list, - fmt_docstring, - kwargs_to_strings, - use_alias, -) +from pygmt.helpers import build_arg_list, fmt_docstring, kwargs_to_strings, use_alias __doctest_skip__ = ["grdimage"] @@ -165,7 +159,7 @@ def grdimage(self, grid: PathLike | xr.DataArray, projection=None, **kwargs): "Parameter 'img_out'/'A' is not implemented. " "Please consider submitting a feature request to us." ) - raise GMTInvalidInput(msg) + raise NotImplementedError(msg) aliasdict = AliasSystem( J=Alias(projection, name="projection"), diff --git a/pygmt/tests/test_grdimage.py b/pygmt/tests/test_grdimage.py index 8df8aab6df9..b0d11c4bdd6 100644 --- a/pygmt/tests/test_grdimage.py +++ b/pygmt/tests/test_grdimage.py @@ -10,7 +10,7 @@ from pygmt.clib import __gmt_version__ from pygmt.datasets import load_earth_relief from pygmt.enums import GridRegistration, GridType -from pygmt.exceptions import GMTInvalidInput, GMTTypeError +from pygmt.exceptions import GMTTypeError from pygmt.helpers.testing import check_figures_equal @@ -252,9 +252,9 @@ def test_grdimage_imgout_fails(grid): Test that an exception is raised if img_out/A is given. """ fig = Figure() - with pytest.raises(GMTInvalidInput): + with pytest.raises(NotImplementedError): fig.grdimage(grid, img_out="out.png") - with pytest.raises(GMTInvalidInput): + with pytest.raises(NotImplementedError): fig.grdimage(grid, A="out.png")