You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* 'master' of https://github.com/prebid/Prebid.js: (38 commits)
Add optional domain parameter to AdButler adapter (prebid#1078)
Send transactionID to Criteo Services (prebid#1113)
Fix `buildMasterVideoTagFromAdserverTag()` not selecting winning bid (prebid#1106)
Remove placement size selection and filtering (prebid#1107)
revert `srcdoc` change (prebid#1130)
Add new Adapter- Beachfront Media (prebid#1062)
Fixes SpringServe adapter (prebid#1101)
Update Widespace request param (prebid#1098)
- New Adapter: Innity (prebid#1074)
Update Roxot prebid analytic adapter (prebid#1034)
Yarn Package Manager (prebid#1109)
allow writing into current document if prebid is loaded inside an iframe (prebid#1066)
Adapter bug fix (prebid#1096)
fix typo
added pr review process and governance model (prebid#1103)
added support for sampling in ga and base adapter, fixed up some tests (prebid#1011)
Add Inneractive adapter (prebid#1048)
Add alias freewheel-ssp to stickyadstv bidder adapter (prebid#1043)
Add Facebook Audience Network adapter (prebid#1068)
Add Atomx support (prebid#1056)
...
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -6,7 +6,7 @@ Thank you for your pull request. Please make sure this PR is scoped to one chang
6
6
<!-- Remove items that don't apply and/or select an item by changing [ ] to [x] -->
7
7
-[ ] Bugfix
8
8
-[ ] Feature
9
-
-[ ] New bidder adapter
9
+
-[ ] New bidder adapter<!-- IMPORTANT: if checking here, also submit your bidder params documentation here https://github.com/prebid/prebid.github.io/tree/master/dev-docs/bidders -->
10
10
-[ ] Code style update (formatting, local variables)
11
11
-[ ] Refactoring (no functional changes, no api changes)
@@ -143,13 +146,15 @@ A watch is also in place that will run continuous tests in the terminal as you e
143
146
144
147
## Contribute
145
148
146
-
Many SSPs, bidders, and publishers have contributed to this project. [20+ Bidders](https://github.com/prebid/Prebid.js/tree/master/src/adapters) are supported by Prebid.js.
149
+
Many SSPs, bidders, and publishers have contributed to this project. [60+ Bidders](https://github.com/prebid/Prebid.js/tree/master/src/adapters) are supported by Prebid.js.
150
+
151
+
Our PR review process can be found [here](https://github.com/prebid/Prebid.js/tree/master/pr_review.md).
147
152
148
153
### Add a Bidder Adapter
149
154
150
155
To add a bidder adapter, see the instructions in [How to add a bidder adaptor](http://prebid.org/dev-docs/bidder-adaptor.html).
151
156
152
-
Please **do NOT load Prebid.js inside your adapter**. If you do this, we will reject or remove your adapter as appropriate.
157
+
Please **do NOT load Prebid.js inside your adapter**. If you do this, we will reject or remove your adapter as appropriate.
153
158
154
159
### Code Quality
155
160
@@ -167,13 +172,13 @@ This will run tests and keep the Karma test browser open. If your `prebid.js` fi
167
172
168
173
+ For test results, see the console
169
174
170
-
+ To set breakpoints in source code, see the developer tools
175
+
+ To set breakpoints in source code, see the developer tools
171
176
172
177
Detailed code coverage reporting can be generated explicitly with
173
178
174
179
$ gulp test --coverage
175
180
176
-
The results will be in
181
+
The results will be in
177
182
178
183
./build/coverage
179
184
@@ -184,3 +189,6 @@ For instructions on writing tests for Prebid.js, see [Testing Prebid.js](http://
184
189
### Supported Browsers
185
190
186
191
Prebid.js is supported on IE9+ and modern browsers.
192
+
193
+
### Governance
194
+
Review our governance model [here](https://github.com/prebid/Prebid.js/tree/master/governance.md).
This document describes the governance model for the Prebid project. The Prebid project’s stated mission is to facilitate fair, transparent, and effective header bidding across the industry, and is responsible for creating and maintaining such projects as [Prebid.js](https://github.com/prebid/Prebid.js).
4
+
5
+
1. A single Tech Lead oversees the technical direction of the project and appoints Core Team members
6
+
2. The Core Team members maintain the project on an ongoing basis with direction from the Tech Lead.
7
+
3. In the event of any disagreements, the Tech Lead will make a final decision.
8
+
4. If there is no Tech Lead available to perform his/her duties, AppNexus Inc. will appoint one.
9
+
10
+
### Roles and Responsibilities:
11
+
-**User:** Any individual who consumes / uses the Prebid.js library.
12
+
-**Contributor:** Any individual who contributes code that is subsequently merged to the project. Contributed code is governed by the Prebid.js [license](https://github.com/prebid/Prebid.js/blob/master/LICENSE). Contributors are required to sign a CLA before any code can be committed (CLA pending).
13
+
-**Core Team Member:** An individual contributor who has been appointed by the Tech Lead on the project to maintain it and further it’s stated goals.
14
+
-**Tech Lead:** The Tech Lead is responsible for overall technical direction of the project. The Tech Lead will work closely with Core Team members to facilitate development and further the project goals.
0 commit comments