test Activity

Author: sladkovm

opendata-python/README.md

@@ -63,7 +63,9 @@ athlete.store_locally(data=False)
 ```
 the rest of the data could always be retrieved later:
 ```python
-athlete.download_remote_data()
+from opendata.models import LocalAthlete
+local_athlete = LocalAthlete(athlete.id)
+local_athlete.download_remote_data()
 ```
 
 ### Working with local data storage

opendata-python/opendata/models.py

@@ -173,4 +173,8 @@ def store_locally(self, data=True):
             self.data_zip.extractall(path=os.path.join(settings.local_storage,
                                                        settings.data_prefix,
                                                        self.id))  # noqa: E501
+        else:
+            warnings.warn(f"""Only metatada will be stored locally for {self.id}.
+                             Data can be fetched later by calling Athlete.download_remote_data()""",
+                             stacklevel=2)
         self.metadata_zip.extractall(path=os.path.join(settings.local_storage, settings.metadata_prefix))  # noqa: E501

opendata-python/tests/test_models.py

@@ -8,19 +8,15 @@
 
 
 class TestActivity:
-    def __init__(self, local_storage):
-        self.activity = models.Activity(
+    def test_init(self, local_storage):
+        activity = models.Activity(
             id='1970_01_01_00_00_00.csv',
             filepath_or_buffer=\
                 os.path.join(local_storage.strpath,
                              settings.data_prefix,
                              'some-athlete-id-1',
                              '1970_01_01_00_00_00.csv')
         )
-        return self
-
-    def test_init(self, local_storage):
-        activity = self.activity
         assert activity.id == '1970_01_01_00_00_00.csv'
         assert activity.filepath_or_buffer == \
             os.path.join(local_storage.strpath,
@@ -32,9 +28,16 @@ def test_init(self, local_storage):
         assert 'heartrate' in activity.data
         assert activity.data.power[0] == 200
 
-    def test_data_not_stored_locally(self, local_storage):
-        data = self.activity.data()
-        assert data is not None
+    def test_init__not_stored_locally(self, local_storage):
+        activity = models.Activity(
+            id='not_stored_activity.csv',
+            filepath_or_buffer=\
+                os.path.join(local_storage.strpath,
+                             settings.data_prefix,
+                             'some-athlete-id-1',
+                             'not_stored_activity.csv')
+        )
+        assert activity is not None
 
 
 class TestBaseAthlete: