Set bigquery connection import id correctly. (#4159)

Author: nat-henderson

products/bigqueryconnection/api.yaml

@@ -28,7 +28,7 @@ objects:
   - !ruby/object:Api::Resource
     name: 'Connection'
     base_url: projects/{{project}}/locations/{{location}}/connections
-    self_link: "{{name}}"
+    self_link: projects/{{project}}/locations/{{location}}/connections/{{connection_id}}
     create_url: projects/{{project}}/locations/{{location}}/connections?connectionId={{connection_id}}
     update_verb: :PATCH
     update_mask: true

products/bigqueryconnection/terraform.yaml

@@ -20,8 +20,8 @@ overrides: !ruby/object:Overrides::ResourceOverrides
         custom_flatten: 'templates/terraform/custom_flatten/bigquery_connection_flatten.go.erb'
       cloudSql.credential.password: !ruby/object:Overrides::Terraform::PropertyOverride
         sensitive: true
-    id_format: "{{name}}"
-    import_format: ["{{name}}"]
+    id_format: "projects/{{project}}/locations/{{location}}/connections/{{connection_id}}"
+    import_format: ["projects/{{project}}/locations/{{location}}/connections/{{connection_id}}", "{{project}}/{{location}}/{{connection_id}}", "{{location}}/{{connection_id}}"]
     examples:
       - !ruby/object:Provider::Terraform::Examples
         min_version: beta

third_party/terraform/tests/resource_bigquery_connection_test.go.erb

@@ -28,9 +28,21 @@ func TestAccBigqueryConnectionConnection_bigqueryConnectionBasic(t *testing.T) {
 			{
 				Config: testAccBigqueryConnectionConnection_bigqueryConnectionBasic(context),
 			},
+			{
+				ImportState:             true,
+				ImportStateVerify:       true,
+                                ImportStateVerifyIgnore: []string{"cloud_sql.0.credential.0.password", "cloud_sql.0.credential.0.username"},
+				ResourceName:            "google_bigquery_connection.connection",
+			},
 			{
 				Config: testAccBigqueryConnectionConnection_bigqueryConnectionBasicUpdate(context),
 			},
+			{
+				ImportState:             true,
+				ImportStateVerify:       true,
+                                ImportStateVerifyIgnore: []string{"cloud_sql.0.credential.0.password", "cloud_sql.0.credential.0.username"},
+				ResourceName:            "google_bigquery_connection.connection",
+			},
 		},
 	})
 }