Skip to content

Commit 5ca713a

Browse files
authored
Ignore members with "deleted:" prefix in bigquery IAM member (#4388)
* Trim "deleted:" prefix from bigquery IAM member parsing * Ignore deleted members
1 parent ab2585e commit 5ca713a

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

third_party/terraform/utils/iam_bigquery_dataset.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,10 @@ func policyToAccess(policy *cloudresourcemanager.Policy) ([]map[string]interface
171171
return nil, fmt.Errorf("BigQuery Dataset legacy role %s is not allowed when using google_bigquery_dataset_iam resources. Please use the full form: %s", binding.Role, fullRole)
172172
}
173173
for _, member := range binding.Members {
174+
// Do not append any deleted members
175+
if strings.HasPrefix(member, "deleted:") {
176+
continue
177+
}
174178
access := map[string]interface{}{
175179
"role": binding.Role,
176180
}
@@ -190,6 +194,10 @@ func policyToAccess(policy *cloudresourcemanager.Policy) ([]map[string]interface
190194
// Dataset access uses different member types to identify groups, domains, etc.
191195
// these types are used as keys in the access JSON payload
192196
func iamMemberToAccess(member string) (string, string, error) {
197+
if strings.HasPrefix(member, "deleted:") {
198+
return "", "", fmt.Errorf("BigQuery Dataset IAM member is deleted: %s", member)
199+
}
200+
193201
pieces := strings.SplitN(member, ":", 2)
194202
if len(pieces) > 1 {
195203
switch pieces[0] {

0 commit comments

Comments
 (0)