From 7fae579c70a151b256fd290075740fbe41995f43 Mon Sep 17 00:00:00 2001 From: averikitsch Date: Thu, 24 Jun 2021 09:35:54 -0700 Subject: [PATCH 1/4] fix run retries --- run/idp-sql/test/system.test.js | 32 ++++++++++++++++++++------------ 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/run/idp-sql/test/system.test.js b/run/idp-sql/test/system.test.js index df07c91416..9c0ad05a0a 100644 --- a/run/idp-sql/test/system.test.js +++ b/run/idp-sql/test/system.test.js @@ -104,9 +104,11 @@ describe('System Tests', () => { it('Can successfully make a request', async () => { const options = { prefixUrl: BASE_URL.trim(), - retry: 3, - statusCodes: [404, 401, 403, 500], - methods: ['GET', 'POST'], + retry: { + limit: 5, + statusCodes: [404, 401, 403, 500], + methods: ['GET', 'POST'], + } }; const response = await got('', options); assert.strictEqual(response.statusCode, 200); @@ -120,9 +122,11 @@ describe('System Tests', () => { headers: { Authorization: `Bearer ${ID_TOKEN.trim()}`, }, - retry: 3, - statusCodes: [404, 401, 403, 500], - methods: ['GET', 'POST'], + retry: { + limit: 5, + statusCodes: [404, 401, 403, 500], + methods: ['GET', 'POST'], + } }; const response = await got('', options); assert.strictEqual(response.statusCode, 200); @@ -136,9 +140,11 @@ describe('System Tests', () => { headers: { Authorization: 'Bearer iam-a-token', }, - retry: 3, - statusCodes: [404, 401, 500], - methods: ['GET', 'POST'], + retry: { + limit: 5, + statusCodes: [404, 401, 403, 500], + methods: ['GET', 'POST'], + } }; let err; try { @@ -154,9 +160,11 @@ describe('System Tests', () => { prefixUrl: BASE_URL.trim(), method: 'POST', form: {team: 'DOGS'}, - retry: 3, - statusCodes: [404, 403, 500], - methods: ['GET', 'POST'], + retry: { + limit: 5, + statusCodes: [404, 401, 403, 500], + methods: ['GET', 'POST'], + } }; let err; try { From 75e75adf1fc25f5c40b42fd0f9ae66c0ea705d3d Mon Sep 17 00:00:00 2001 From: averikitsch Date: Thu, 24 Jun 2021 10:06:25 -0700 Subject: [PATCH 2/4] lint --- run/idp-sql/test/system.test.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/run/idp-sql/test/system.test.js b/run/idp-sql/test/system.test.js index 9c0ad05a0a..ab7f93b572 100644 --- a/run/idp-sql/test/system.test.js +++ b/run/idp-sql/test/system.test.js @@ -108,7 +108,7 @@ describe('System Tests', () => { limit: 5, statusCodes: [404, 401, 403, 500], methods: ['GET', 'POST'], - } + }, }; const response = await got('', options); assert.strictEqual(response.statusCode, 200); @@ -126,7 +126,7 @@ describe('System Tests', () => { limit: 5, statusCodes: [404, 401, 403, 500], methods: ['GET', 'POST'], - } + }, }; const response = await got('', options); assert.strictEqual(response.statusCode, 200); @@ -144,7 +144,7 @@ describe('System Tests', () => { limit: 5, statusCodes: [404, 401, 403, 500], methods: ['GET', 'POST'], - } + }, }; let err; try { @@ -164,7 +164,7 @@ describe('System Tests', () => { limit: 5, statusCodes: [404, 401, 403, 500], methods: ['GET', 'POST'], - } + }, }; let err; try { From ed5bc9a32486497e0517a0e5fadec692ff926afa Mon Sep 17 00:00:00 2001 From: averikitsch Date: Thu, 24 Jun 2021 10:33:00 -0700 Subject: [PATCH 3/4] debug --- run/idp-sql/test/system.test.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/run/idp-sql/test/system.test.js b/run/idp-sql/test/system.test.js index ab7f93b572..83e657a390 100644 --- a/run/idp-sql/test/system.test.js +++ b/run/idp-sql/test/system.test.js @@ -142,7 +142,7 @@ describe('System Tests', () => { }, retry: { limit: 5, - statusCodes: [404, 401, 403, 500], + statusCodes: [404, 401, 500], methods: ['GET', 'POST'], }, }; @@ -152,6 +152,8 @@ describe('System Tests', () => { } catch (e) { err = e; } + console.lpg(err.response.retryCount) + console.log(err.request.options.headers) assert.strictEqual(err.response.statusCode, 403); }); From 2009a086ec97c8b03f9c8f50850cceb80a6a82bc Mon Sep 17 00:00:00 2001 From: averikitsch Date: Thu, 24 Jun 2021 10:41:11 -0700 Subject: [PATCH 4/4] fix lint --- run/idp-sql/test/system.test.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/run/idp-sql/test/system.test.js b/run/idp-sql/test/system.test.js index 83e657a390..ffd08db136 100644 --- a/run/idp-sql/test/system.test.js +++ b/run/idp-sql/test/system.test.js @@ -152,8 +152,8 @@ describe('System Tests', () => { } catch (e) { err = e; } - console.lpg(err.response.retryCount) - console.log(err.request.options.headers) + console.log(err.response.retryCount); + console.log(err.request.options.headers); assert.strictEqual(err.response.statusCode, 403); });