Skip to content

feat: adding unit tests, removing unused arg from README#93

Merged
bradmiro merged 9 commits intoGoogleCloudPlatform:mainfrom
bradmiro:unit-tests
Dec 18, 2023
Merged

feat: adding unit tests, removing unused arg from README#93
bradmiro merged 9 commits intoGoogleCloudPlatform:mainfrom
bradmiro:unit-tests

Conversation

@bradmiro
Copy link
Copy Markdown
Collaborator

@bradmiro bradmiro commented Nov 2, 2023

Adding unit tests:

  • assert copy-data and project-setup workflows finished in the "SUCCEEDED" state
  • assert BigQuery tables are created and nonempty
  • assert exactly one Dataproc cluster is crated
  • assert Dataproc cluster is in the "TERMINATED" (stopped) state

Updating README to remove a deprecated command line arg

@bradmiro bradmiro requested review from a team and davenportjw as code owners November 2, 2023 18:22
@bradmiro bradmiro changed the title feat: (WIP) adding unit tests, removing unused arg from README feat: adding unit tests, removing unused arg from README Nov 3, 2023
@bradmiro
Copy link
Copy Markdown
Collaborator Author

bradmiro commented Nov 6, 2023

/gcbrun

@bradmiro bradmiro force-pushed the unit-tests branch 4 times, most recently from 047bbad to 57e411c Compare November 10, 2023 21:33
@bradmiro bradmiro force-pushed the unit-tests branch 14 times, most recently from 5c9029f to dd7c6bf Compare November 22, 2023 21:08
@bradmiro bradmiro force-pushed the unit-tests branch 4 times, most recently from 734819c to bf7317b Compare December 7, 2023 22:17
@bradmiro bradmiro merged commit bb9257b into GoogleCloudPlatform:main Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants