Remove JetBrains' annotations for internal classes

odinserj · odinserj · commit 8e694d07e50e · 2025-04-18T15:06:19.000+07:00
The project has Nullable Reference Types feature enabled, so these annotations aren't required anymore for internal classes.
diff --git a/src/Hangfire.InMemory/GlobalConfigurationExtensions.cs b/src/Hangfire.InMemory/GlobalConfigurationExtensions.cs
@@ -26,6 +26,7 @@ namespace Hangfire
     /// Provides extension methods for global configuration to use <see cref="InMemoryStorage"/>.
     /// </summary>
     [EditorBrowsable(EditorBrowsableState.Never)]
+    [SuppressMessage("ReSharper", "RedundantNullnessAttributeWithNullableReferenceTypes", Justification = "Should be used for public classes")]
     public static class GlobalConfigurationExtensions
     {
         /// <summary>
diff --git a/src/Hangfire.InMemory/InMemoryConnection.cs b/src/Hangfire.InMemory/InMemoryConnection.cs
@@ -17,7 +17,6 @@
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading;
-using Hangfire.Annotations;
 using Hangfire.Common;
 using Hangfire.InMemory.Entities;
 using Hangfire.InMemory.State;
@@ -31,7 +30,7 @@ internal sealed class InMemoryConnection<TKey> : JobStorageConnection
     {
         private readonly List<LockDisposable> _acquiredLocks = new();
 
-        public InMemoryConnection([NotNull] InMemoryStorageOptions options, [NotNull] DispatcherBase<TKey> dispatcher, [NotNull] IKeyProvider<TKey> keyProvider)
+        public InMemoryConnection(InMemoryStorageOptions options, DispatcherBase<TKey> dispatcher, IKeyProvider<TKey> keyProvider)
         {
             Options = options ?? throw new ArgumentNullException(nameof(options));
             Dispatcher = dispatcher ?? throw new ArgumentNullException(nameof(dispatcher));
@@ -57,7 +56,7 @@ public override IWriteOnlyTransaction CreateWriteTransaction()
             return new InMemoryTransaction<TKey>(this);
         }
 
-        public override IDisposable AcquireDistributedLock([NotNull] string resource, TimeSpan timeout)
+        public override IDisposable AcquireDistributedLock(string resource, TimeSpan timeout)
         {
             if (resource == null) throw new ArgumentNullException(nameof(resource));
 
@@ -70,8 +69,8 @@ public override IDisposable AcquireDistributedLock([NotNull] string resource, Ti
         }
 
         public override string CreateExpiredJob(
-            [NotNull] Job job,
-            [NotNull] IDictionary<string, string?> parameters,
+            Job job,
+            IDictionary<string, string?> parameters,
             DateTime createdAt,
             TimeSpan expireIn)
         {
@@ -86,7 +85,7 @@ public override string CreateExpiredJob(
             return KeyProvider.ToString(key);
         }
 
-        public override IFetchedJob FetchNextJob([NotNull] string[] queues, CancellationToken cancellationToken)
+        public override IFetchedJob FetchNextJob(string[] queues, CancellationToken cancellationToken)
         {
             if (queues == null) throw new ArgumentNullException(nameof(queues));
             if (queues.Length == 0) throw new ArgumentException("Queue array must be non-empty.", nameof(queues));
@@ -158,7 +157,7 @@ private InMemoryFetchedJob<TKey> FetchNextJobSlow(KeyValuePair<string, QueueEntr
             }
         }
 
-        public override void SetJobParameter([NotNull] string id, [NotNull] string name, [CanBeNull] string? value)
+        public override void SetJobParameter(string id, string name, string? value)
         {
             if (id == null) throw new ArgumentNullException(nameof(id));
             if (name == null) throw new ArgumentNullException(nameof(name));
@@ -171,7 +170,7 @@ public override void SetJobParameter([NotNull] string id, [NotNull] string name,
             Dispatcher.QueryWriteAndWait(new Commands<TKey>.JobSetParameter(key, name, value));
         }
 
-        public override string? GetJobParameter([NotNull] string id, [NotNull] string name)
+        public override string? GetJobParameter(string id, string name)
         {
             if (id == null) throw new ArgumentNullException(nameof(id));
             if (name == null) throw new ArgumentNullException(nameof(name));
@@ -184,7 +183,7 @@ public override void SetJobParameter([NotNull] string id, [NotNull] string name,
             return Dispatcher.QueryReadAndWait(new Queries<TKey>.JobGetParameter(key, name), static (q, s) => q.Execute(s));
         }
 
-        public override JobData? GetJobData([NotNull] string jobId)
+        public override JobData? GetJobData(string jobId)
         {
             if (jobId == null) throw new ArgumentNullException(nameof(jobId));
 
@@ -209,7 +208,7 @@ public override void SetJobParameter([NotNull] string id, [NotNull] string name,
             };
         }
 
-        public override StateData? GetStateData([NotNull] string jobId)
+        public override StateData? GetStateData(string jobId)
         {
             if (jobId == null) throw new ArgumentNullException(nameof(jobId));
 
@@ -229,7 +228,7 @@ public override void SetJobParameter([NotNull] string id, [NotNull] string name,
             };
         }
 
-        public override void AnnounceServer([NotNull] string serverId, [NotNull] ServerContext context)
+        public override void AnnounceServer(string serverId, ServerContext context)
         {
             if (serverId == null) throw new ArgumentNullException(nameof(serverId));
             if (context == null) throw new ArgumentNullException(nameof(context));
@@ -238,14 +237,14 @@ public override void AnnounceServer([NotNull] string serverId, [NotNull] ServerC
             Dispatcher.QueryWriteAndWait(new Commands<TKey>.ServerAnnounce(serverId, context, now), static (c, s) => c.Execute(s));
         }
 
-        public override void RemoveServer([NotNull] string serverId)
+        public override void RemoveServer(string serverId)
         {
             if (serverId == null) throw new ArgumentNullException(nameof(serverId));
 
             Dispatcher.QueryWriteAndWait(new Commands<TKey>.ServerDelete(serverId), static (c, s) => c.Execute(s));
         }
 
-        public override void Heartbeat([NotNull] string serverId)
+        public override void Heartbeat(string serverId)
         {
             if (serverId == null) throw new ArgumentNullException(nameof(serverId));
 
@@ -276,14 +275,14 @@ public override DateTime GetUtcDateTime()
         }
 #endif
 
-        public override HashSet<string> GetAllItemsFromSet([NotNull] string key)
+        public override HashSet<string> GetAllItemsFromSet(string key)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
 
             return Dispatcher.QueryReadAndWait(new Queries<TKey>.SortedSetGetAll(key), static (q, s) => q.Execute(s));
         }
 
-        public override string? GetFirstByLowestScoreFromSet([NotNull] string key, double fromScore, double toScore)
+        public override string? GetFirstByLowestScoreFromSet(string key, double fromScore, double toScore)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
             if (toScore < fromScore) throw new ArgumentException("The `toScore` value must be greater or equal to the `fromScore` value.", nameof(toScore));
@@ -293,7 +292,7 @@ public override HashSet<string> GetAllItemsFromSet([NotNull] string key)
                 static (q, s) => q.Execute(s));
         }
 
-        public override List<string> GetFirstByLowestScoreFromSet([NotNull] string key, double fromScore, double toScore, int count)
+        public override List<string> GetFirstByLowestScoreFromSet(string key, double fromScore, double toScore, int count)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
             if (toScore < fromScore) throw new ArgumentException("The `toScore` value must be greater or equal to the `fromScore` value.", nameof(toScore));
@@ -305,7 +304,7 @@ public override List<string> GetFirstByLowestScoreFromSet([NotNull] string key,
         }
 
 #if !HANGFIRE_170
-        public override bool GetSetContains([NotNull] string key, [NotNull] string value)
+        public override bool GetSetContains(string key, string value)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
             if (value == null) throw new ArgumentNullException(nameof(value));
@@ -314,15 +313,15 @@ public override bool GetSetContains([NotNull] string key, [NotNull] string value
         }
 #endif
 
-        public override long GetSetCount([NotNull] string key)
+        public override long GetSetCount(string key)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
 
             return Dispatcher.QueryReadAndWait(new Queries<TKey>.SortedSetCount(key), static (q, s) => q.Execute(s));
         }
 
 #if !HANGFIRE_170
-        public override long GetSetCount([NotNull] IEnumerable<string> keys, int limit)
+        public override long GetSetCount(IEnumerable<string> keys, int limit)
         {
             if (keys == null) throw new ArgumentNullException(nameof(keys));
             if (limit < 0) throw new ArgumentOutOfRangeException(nameof(limit), "Value must be greater or equal to 0.");
@@ -333,28 +332,28 @@ public override long GetSetCount([NotNull] IEnumerable<string> keys, int limit)
         }
 #endif
 
-        public override long GetListCount([NotNull] string key)
+        public override long GetListCount(string key)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
 
             return Dispatcher.QueryReadAndWait(new Queries<TKey>.ListCount(key), static (q, s) => q.Execute(s));
         }
 
-        public override long GetCounter([NotNull] string key)
+        public override long GetCounter(string key)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
 
             return Dispatcher.QueryReadAndWait(new Queries<TKey>.CounterGet(key), static (q, s) => q.Execute(s));
         }
 
-        public override long GetHashCount([NotNull] string key)
+        public override long GetHashCount(string key)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
 
             return Dispatcher.QueryReadAndWait(new Queries<TKey>.HashFieldCount(key), static (q, s) => q.Execute(s));
         }
 
-        public override TimeSpan GetHashTtl([NotNull] string key)
+        public override TimeSpan GetHashTtl(string key)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
 
@@ -367,7 +366,7 @@ public override TimeSpan GetHashTtl([NotNull] string key)
             return expireIn >= TimeSpan.Zero ? expireIn : TimeSpan.Zero;
         }
 
-        public override TimeSpan GetListTtl([NotNull] string key)
+        public override TimeSpan GetListTtl(string key)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
 
@@ -380,7 +379,7 @@ public override TimeSpan GetListTtl([NotNull] string key)
             return expireIn >= TimeSpan.Zero ? expireIn : TimeSpan.Zero;
         }
 
-        public override TimeSpan GetSetTtl([NotNull] string key)
+        public override TimeSpan GetSetTtl(string key)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
 
@@ -393,37 +392,37 @@ public override TimeSpan GetSetTtl([NotNull] string key)
             return expireIn >= TimeSpan.Zero ? expireIn : TimeSpan.Zero;
         }
 
-        public override void SetRangeInHash([NotNull] string key, [NotNull] IEnumerable<KeyValuePair<string, string>> keyValuePairs)
+        public override void SetRangeInHash(string key, IEnumerable<KeyValuePair<string, string>> keyValuePairs)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
             if (keyValuePairs == null) throw new ArgumentNullException(nameof(keyValuePairs));
 
             Dispatcher.QueryWriteAndWait(new Commands<TKey>.HashSetRange(key, keyValuePairs));
         }
 
-        public override Dictionary<string, string>? GetAllEntriesFromHash([NotNull] string key)
+        public override Dictionary<string, string>? GetAllEntriesFromHash(string key)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
 
             return Dispatcher.QueryReadAndWait(new Queries<TKey>.HashGetAll(key), static (q, s) => q.Execute(s));
         }
 
-        public override string? GetValueFromHash([NotNull] string key, [NotNull] string name)
+        public override string? GetValueFromHash(string key, string name)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
             if (name == null) throw new ArgumentNullException(nameof(name));
 
             return Dispatcher.QueryReadAndWait(new Queries<TKey>.HashGet(key, name), static (q, s) => q.Execute(s));
         }
 
-        public override List<string> GetAllItemsFromList([NotNull] string key)
+        public override List<string> GetAllItemsFromList(string key)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
 
             return Dispatcher.QueryReadAndWait(new Queries<TKey>.ListGetAll(key), static (q, s) => q.Execute(s));
         }
 
-        public override List<string> GetRangeFromList([NotNull] string key, int startingFrom, int endingAt)
+        public override List<string> GetRangeFromList(string key, int startingFrom, int endingAt)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
             if (startingFrom < 0) throw new ArgumentException("The value must be greater than or equal to zero.", nameof(startingFrom));
@@ -432,7 +431,7 @@ public override List<string> GetRangeFromList([NotNull] string key, int starting
             return Dispatcher.QueryReadAndWait(new Queries<TKey>.ListRange(key, startingFrom, endingAt), static (q, s) => q.Execute(s));
         }
 
-        public override List<string> GetRangeFromSet([NotNull] string key, int startingFrom, int endingAt)
+        public override List<string> GetRangeFromSet(string key, int startingFrom, int endingAt)
         {
             if (key == null) throw new ArgumentNullException(nameof(key));
             if (startingFrom < 0) throw new ArgumentException("The value must be greater than or equal to zero.", nameof(startingFrom));
diff --git a/src/Hangfire.InMemory/InMemoryFetchedJob.cs b/src/Hangfire.InMemory/InMemoryFetchedJob.cs
@@ -14,7 +14,6 @@
 // License along with Hangfire. If not, see <http://www.gnu.org/licenses/>.
 
 using System;
-using Hangfire.Annotations;
 using Hangfire.InMemory.State;
 using Hangfire.Storage;
 
@@ -26,9 +25,9 @@ internal sealed class InMemoryFetchedJob<TKey> : IFetchedJob
         private readonly InMemoryConnection<TKey> _connection;
 
         public InMemoryFetchedJob(
-            [NotNull] InMemoryConnection<TKey> connection,
-            [NotNull] string queueName,
-            [NotNull] string jobId)
+            InMemoryConnection<TKey> connection,
+            string queueName,
+            string jobId)
         {
             _connection = connection ?? throw new ArgumentNullException(nameof(connection));
 
diff --git a/src/Hangfire.InMemory/InMemoryMonitoringApi.cs b/src/Hangfire.InMemory/InMemoryMonitoringApi.cs
@@ -18,7 +18,6 @@
 using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Linq;
-using Hangfire.Annotations;
 using Hangfire.Common;
 using Hangfire.InMemory.State;
 using Hangfire.States;
@@ -54,7 +53,7 @@ internal sealed class InMemoryMonitoringApi<TKey> : JobStorageMonitor
         private readonly DispatcherBase<TKey> _dispatcher;
         private readonly IKeyProvider<TKey> _keyProvider;
 
-        public InMemoryMonitoringApi([NotNull] DispatcherBase<TKey> dispatcher, [NotNull] IKeyProvider<TKey> keyProvider)
+        public InMemoryMonitoringApi(DispatcherBase<TKey> dispatcher, IKeyProvider<TKey> keyProvider)
         {
             _dispatcher = dispatcher ?? throw new ArgumentNullException(nameof(dispatcher));
             _keyProvider = keyProvider ?? throw new ArgumentNullException(nameof(keyProvider));
@@ -107,7 +106,7 @@ public override IList<ServerDto> Servers()
             }).ToList();
         }
 
-        public override JobDetailsDto? JobDetails([NotNull] string jobId)
+        public override JobDetailsDto? JobDetails(string jobId)
         {
             if (jobId == null) throw new ArgumentNullException(nameof(jobId));
 
@@ -165,7 +164,7 @@ public override StatisticsDto GetStatistics()
             };
         }
 
-        public override JobList<EnqueuedJobDto> EnqueuedJobs([NotNull] string queue, int from, int perPage)
+        public override JobList<EnqueuedJobDto> EnqueuedJobs(string queue, int from, int perPage)
         {
             if (queue == null) throw new ArgumentNullException(nameof(queue));
 
@@ -190,7 +189,7 @@ public override JobList<EnqueuedJobDto> EnqueuedJobs([NotNull] string queue, int
                 })));
         }
 
-        public override JobList<FetchedJobDto> FetchedJobs([NotNull] string queue, int from, int perPage)
+        public override JobList<FetchedJobDto> FetchedJobs(string queue, int from, int perPage)
         {
             if (queue == null) throw new ArgumentNullException(nameof(queue));
             return new JobList<FetchedJobDto>([]);
@@ -380,13 +379,13 @@ public override long ScheduledCount()
             return GetCountByStateName(ScheduledState.StateName);
         }
 
-        public override long EnqueuedCount([NotNull] string queue)
+        public override long EnqueuedCount(string queue)
         {
             if (queue == null) throw new ArgumentNullException(nameof(queue));
             return _dispatcher.QueryReadAndWait(new MonitoringQueries<TKey>.QueueGetCount(queue), static (q, s) => q.Execute(s));
         }
 
-        public override long FetchedCount([NotNull] string queue)
+        public override long FetchedCount(string queue)
         {
             if (queue == null) throw new ArgumentNullException(nameof(queue));
             return 0;
diff --git a/src/Hangfire.InMemory/InMemoryStorage.cs b/src/Hangfire.InMemory/InMemoryStorage.cs
@@ -14,6 +14,7 @@
 // License along with Hangfire. If not, see <http://www.gnu.org/licenses/>.
 
 using System;
+using System.Diagnostics.CodeAnalysis;
 #if !HANGFIRE_170
 using System.Collections.Generic;
 #endif
@@ -29,6 +30,7 @@ namespace Hangfire.InMemory
     /// A class that represents an in-memory job storage that stores all data
     /// related to background processing in a process' memory.
     /// </summary>
+    [SuppressMessage("ReSharper", "RedundantNullnessAttributeWithNullableReferenceTypes", Justification = "Should be used for public classes")]
     public sealed class InMemoryStorage : JobStorage, IKeyProvider<Guid>, IKeyProvider<ulong>, IDisposable
     {
         private readonly Dispatcher<Guid>? _guidDispatcher;
diff --git a/src/Hangfire.InMemory/InMemoryTransaction.cs b/src/Hangfire.InMemory/InMemoryTransaction.cs

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@ namespace Hangfire`
`26`	`26`	`/// Provides extension methods for global configuration to use <see cref="InMemoryStorage"/>.`
`27`	`27`	`/// </summary>`
`28`	`28`	`[EditorBrowsable(EditorBrowsableState.Never)]`
	`29`	`+ [SuppressMessage("ReSharper", "RedundantNullnessAttributeWithNullableReferenceTypes", Justification = "Should be used for public classes")]`
`29`	`30`	`public static class GlobalConfigurationExtensions`
`30`	`31`	`{`
`31`	`32`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`	`using System.Collections.Generic;`
`18`	`18`	`using System.Linq;`
`19`	`19`	`using System.Threading;`
`20`		`-using Hangfire.Annotations;`
`21`	`20`	`using Hangfire.Common;`
`22`	`21`	`using Hangfire.InMemory.Entities;`
`23`	`22`	`using Hangfire.InMemory.State;`
`@@ -31,7 +30,7 @@ internal sealed class InMemoryConnection<TKey> : JobStorageConnection`
`31`	`30`	`{`
`32`	`31`	`private readonly List<LockDisposable> _acquiredLocks = new();`
`33`	`32`
`34`		`- public InMemoryConnection([NotNull] InMemoryStorageOptions options, [NotNull] DispatcherBase<TKey> dispatcher, [NotNull] IKeyProvider<TKey> keyProvider)`
	`33`	`+ public InMemoryConnection(InMemoryStorageOptions options, DispatcherBase<TKey> dispatcher, IKeyProvider<TKey> keyProvider)`
`35`	`34`	`{`
`36`	`35`	`Options = options ?? throw new ArgumentNullException(nameof(options));`
`37`	`36`	`Dispatcher = dispatcher ?? throw new ArgumentNullException(nameof(dispatcher));`
`@@ -57,7 +56,7 @@ public override IWriteOnlyTransaction CreateWriteTransaction()`
`57`	`56`	`return new InMemoryTransaction<TKey>(this);`
`58`	`57`	`}`
`59`	`58`
`60`		`- public override IDisposable AcquireDistributedLock([NotNull] string resource, TimeSpan timeout)`
	`59`	`+ public override IDisposable AcquireDistributedLock(string resource, TimeSpan timeout)`
`61`	`60`	`{`
`62`	`61`	`if (resource == null) throw new ArgumentNullException(nameof(resource));`
`63`	`62`
`@@ -70,8 +69,8 @@ public override IDisposable AcquireDistributedLock([NotNull] string resource, Ti`
`70`	`69`	`}`
`71`	`70`
`72`	`71`	`public override string CreateExpiredJob(`
`73`		`- [NotNull] Job job,`
`74`		`- [NotNull] IDictionary<string, string?> parameters,`
	`72`	`+ Job job,`
	`73`	`+ IDictionary<string, string?> parameters,`
`75`	`74`	`DateTime createdAt,`
`76`	`75`	`TimeSpan expireIn)`
`77`	`76`	`{`
`@@ -86,7 +85,7 @@ public override string CreateExpiredJob(`
`86`	`85`	`return KeyProvider.ToString(key);`
`87`	`86`	`}`
`88`	`87`
`89`		`- public override IFetchedJob FetchNextJob([NotNull] string[] queues, CancellationToken cancellationToken)`
	`88`	`+ public override IFetchedJob FetchNextJob(string[] queues, CancellationToken cancellationToken)`
`90`	`89`	`{`
`91`	`90`	`if (queues == null) throw new ArgumentNullException(nameof(queues));`
`92`	`91`	`if (queues.Length == 0) throw new ArgumentException("Queue array must be non-empty.", nameof(queues));`
`@@ -158,7 +157,7 @@ private InMemoryFetchedJob<TKey> FetchNextJobSlow(KeyValuePair<string, QueueEntr`
`158`	`157`	`}`
`159`	`158`	`}`
`160`	`159`
`161`		`- public override void SetJobParameter([NotNull] string id, [NotNull] string name, [CanBeNull] string? value)`
	`160`	`+ public override void SetJobParameter(string id, string name, string? value)`
`162`	`161`	`{`
`163`	`162`	`if (id == null) throw new ArgumentNullException(nameof(id));`
`164`	`163`	`if (name == null) throw new ArgumentNullException(nameof(name));`
`@@ -171,7 +170,7 @@ public override void SetJobParameter([NotNull] string id, [NotNull] string name,`
`171`	`170`	`Dispatcher.QueryWriteAndWait(new Commands<TKey>.JobSetParameter(key, name, value));`
`172`	`171`	`}`
`173`	`172`
`174`		`- public override string? GetJobParameter([NotNull] string id, [NotNull] string name)`
	`173`	`+ public override string? GetJobParameter(string id, string name)`
`175`	`174`	`{`
`176`	`175`	`if (id == null) throw new ArgumentNullException(nameof(id));`
`177`	`176`	`if (name == null) throw new ArgumentNullException(nameof(name));`
`@@ -184,7 +183,7 @@ public override void SetJobParameter([NotNull] string id, [NotNull] string name,`
`184`	`183`	`return Dispatcher.QueryReadAndWait(new Queries<TKey>.JobGetParameter(key, name), static (q, s) => q.Execute(s));`
`185`	`184`	`}`
`186`	`185`
`187`		`- public override JobData? GetJobData([NotNull] string jobId)`
	`186`	`+ public override JobData? GetJobData(string jobId)`
`188`	`187`	`{`
`189`	`188`	`if (jobId == null) throw new ArgumentNullException(nameof(jobId));`
`190`	`189`
`@@ -209,7 +208,7 @@ public override void SetJobParameter([NotNull] string id, [NotNull] string name,`
`209`	`208`	`};`
`210`	`209`	`}`
`211`	`210`
`212`		`- public override StateData? GetStateData([NotNull] string jobId)`
	`211`	`+ public override StateData? GetStateData(string jobId)`
`213`	`212`	`{`
`214`	`213`	`if (jobId == null) throw new ArgumentNullException(nameof(jobId));`
`215`	`214`
`@@ -229,7 +228,7 @@ public override void SetJobParameter([NotNull] string id, [NotNull] string name,`
`229`	`228`	`};`
`230`	`229`	`}`
`231`	`230`
`232`		`- public override void AnnounceServer([NotNull] string serverId, [NotNull] ServerContext context)`
	`231`	`+ public override void AnnounceServer(string serverId, ServerContext context)`
`233`	`232`	`{`
`234`	`233`	`if (serverId == null) throw new ArgumentNullException(nameof(serverId));`
`235`	`234`	`if (context == null) throw new ArgumentNullException(nameof(context));`
`@@ -238,14 +237,14 @@ public override void AnnounceServer([NotNull] string serverId, [NotNull] ServerC`
`238`	`237`	`Dispatcher.QueryWriteAndWait(new Commands<TKey>.ServerAnnounce(serverId, context, now), static (c, s) => c.Execute(s));`
`239`	`238`	`}`
`240`	`239`
`241`		`- public override void RemoveServer([NotNull] string serverId)`
	`240`	`+ public override void RemoveServer(string serverId)`
`242`	`241`	`{`
`243`	`242`	`if (serverId == null) throw new ArgumentNullException(nameof(serverId));`
`244`	`243`
`245`	`244`	`Dispatcher.QueryWriteAndWait(new Commands<TKey>.ServerDelete(serverId), static (c, s) => c.Execute(s));`
`246`	`245`	`}`
`247`	`246`
`248`		`- public override void Heartbeat([NotNull] string serverId)`
	`247`	`+ public override void Heartbeat(string serverId)`
`249`	`248`	`{`
`250`	`249`	`if (serverId == null) throw new ArgumentNullException(nameof(serverId));`
`251`	`250`
`@@ -276,14 +275,14 @@ public override DateTime GetUtcDateTime()`
`276`	`275`	`}`
`277`	`276`	`#endif`
`278`	`277`
`279`		`- public override HashSet<string> GetAllItemsFromSet([NotNull] string key)`
	`278`	`+ public override HashSet<string> GetAllItemsFromSet(string key)`
`280`	`279`	`{`
`281`	`280`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`282`	`281`
`283`	`282`	`return Dispatcher.QueryReadAndWait(new Queries<TKey>.SortedSetGetAll(key), static (q, s) => q.Execute(s));`
`284`	`283`	`}`
`285`	`284`
`286`		`- public override string? GetFirstByLowestScoreFromSet([NotNull] string key, double fromScore, double toScore)`
	`285`	`+ public override string? GetFirstByLowestScoreFromSet(string key, double fromScore, double toScore)`
`287`	`286`	`{`
`288`	`287`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`289`	`288`	if (toScore < fromScore) throw new ArgumentException("The `toScore` value must be greater or equal to the `fromScore` value.", nameof(toScore));
`@@ -293,7 +292,7 @@ public override HashSet<string> GetAllItemsFromSet([NotNull] string key)`
`293`	`292`	`static (q, s) => q.Execute(s));`
`294`	`293`	`}`
`295`	`294`
`296`		`- public override List<string> GetFirstByLowestScoreFromSet([NotNull] string key, double fromScore, double toScore, int count)`
	`295`	`+ public override List<string> GetFirstByLowestScoreFromSet(string key, double fromScore, double toScore, int count)`
`297`	`296`	`{`
`298`	`297`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`299`	`298`	if (toScore < fromScore) throw new ArgumentException("The `toScore` value must be greater or equal to the `fromScore` value.", nameof(toScore));
`@@ -305,7 +304,7 @@ public override List<string> GetFirstByLowestScoreFromSet([NotNull] string key,`
`305`	`304`	`}`
`306`	`305`
`307`	`306`	`#if !HANGFIRE_170`
`308`		`- public override bool GetSetContains([NotNull] string key, [NotNull] string value)`
	`307`	`+ public override bool GetSetContains(string key, string value)`
`309`	`308`	`{`
`310`	`309`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`311`	`310`	`if (value == null) throw new ArgumentNullException(nameof(value));`
`@@ -314,15 +313,15 @@ public override bool GetSetContains([NotNull] string key, [NotNull] string value`
`314`	`313`	`}`
`315`	`314`	`#endif`
`316`	`315`
`317`		`- public override long GetSetCount([NotNull] string key)`
	`316`	`+ public override long GetSetCount(string key)`
`318`	`317`	`{`
`319`	`318`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`320`	`319`
`321`	`320`	`return Dispatcher.QueryReadAndWait(new Queries<TKey>.SortedSetCount(key), static (q, s) => q.Execute(s));`
`322`	`321`	`}`
`323`	`322`
`324`	`323`	`#if !HANGFIRE_170`
`325`		`- public override long GetSetCount([NotNull] IEnumerable<string> keys, int limit)`
	`324`	`+ public override long GetSetCount(IEnumerable<string> keys, int limit)`
`326`	`325`	`{`
`327`	`326`	`if (keys == null) throw new ArgumentNullException(nameof(keys));`
`328`	`327`	`if (limit < 0) throw new ArgumentOutOfRangeException(nameof(limit), "Value must be greater or equal to 0.");`
`@@ -333,28 +332,28 @@ public override long GetSetCount([NotNull] IEnumerable<string> keys, int limit)`
`333`	`332`	`}`
`334`	`333`	`#endif`
`335`	`334`
`336`		`- public override long GetListCount([NotNull] string key)`
	`335`	`+ public override long GetListCount(string key)`
`337`	`336`	`{`
`338`	`337`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`339`	`338`
`340`	`339`	`return Dispatcher.QueryReadAndWait(new Queries<TKey>.ListCount(key), static (q, s) => q.Execute(s));`
`341`	`340`	`}`
`342`	`341`
`343`		`- public override long GetCounter([NotNull] string key)`
	`342`	`+ public override long GetCounter(string key)`
`344`	`343`	`{`
`345`	`344`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`346`	`345`
`347`	`346`	`return Dispatcher.QueryReadAndWait(new Queries<TKey>.CounterGet(key), static (q, s) => q.Execute(s));`
`348`	`347`	`}`
`349`	`348`
`350`		`- public override long GetHashCount([NotNull] string key)`
	`349`	`+ public override long GetHashCount(string key)`
`351`	`350`	`{`
`352`	`351`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`353`	`352`
`354`	`353`	`return Dispatcher.QueryReadAndWait(new Queries<TKey>.HashFieldCount(key), static (q, s) => q.Execute(s));`
`355`	`354`	`}`
`356`	`355`
`357`		`- public override TimeSpan GetHashTtl([NotNull] string key)`
	`356`	`+ public override TimeSpan GetHashTtl(string key)`
`358`	`357`	`{`
`359`	`358`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`360`	`359`
`@@ -367,7 +366,7 @@ public override TimeSpan GetHashTtl([NotNull] string key)`
`367`	`366`	`return expireIn >= TimeSpan.Zero ? expireIn : TimeSpan.Zero;`
`368`	`367`	`}`
`369`	`368`
`370`		`- public override TimeSpan GetListTtl([NotNull] string key)`
	`369`	`+ public override TimeSpan GetListTtl(string key)`
`371`	`370`	`{`
`372`	`371`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`373`	`372`
`@@ -380,7 +379,7 @@ public override TimeSpan GetListTtl([NotNull] string key)`
`380`	`379`	`return expireIn >= TimeSpan.Zero ? expireIn : TimeSpan.Zero;`
`381`	`380`	`}`
`382`	`381`
`383`		`- public override TimeSpan GetSetTtl([NotNull] string key)`
	`382`	`+ public override TimeSpan GetSetTtl(string key)`
`384`	`383`	`{`
`385`	`384`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`386`	`385`
`@@ -393,37 +392,37 @@ public override TimeSpan GetSetTtl([NotNull] string key)`
`393`	`392`	`return expireIn >= TimeSpan.Zero ? expireIn : TimeSpan.Zero;`
`394`	`393`	`}`
`395`	`394`
`396`		`- public override void SetRangeInHash([NotNull] string key, [NotNull] IEnumerable<KeyValuePair<string, string>> keyValuePairs)`
	`395`	`+ public override void SetRangeInHash(string key, IEnumerable<KeyValuePair<string, string>> keyValuePairs)`
`397`	`396`	`{`
`398`	`397`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`399`	`398`	`if (keyValuePairs == null) throw new ArgumentNullException(nameof(keyValuePairs));`
`400`	`399`
`401`	`400`	`Dispatcher.QueryWriteAndWait(new Commands<TKey>.HashSetRange(key, keyValuePairs));`
`402`	`401`	`}`
`403`	`402`
`404`		`- public override Dictionary<string, string>? GetAllEntriesFromHash([NotNull] string key)`
	`403`	`+ public override Dictionary<string, string>? GetAllEntriesFromHash(string key)`
`405`	`404`	`{`
`406`	`405`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`407`	`406`
`408`	`407`	`return Dispatcher.QueryReadAndWait(new Queries<TKey>.HashGetAll(key), static (q, s) => q.Execute(s));`
`409`	`408`	`}`
`410`	`409`
`411`		`- public override string? GetValueFromHash([NotNull] string key, [NotNull] string name)`
	`410`	`+ public override string? GetValueFromHash(string key, string name)`
`412`	`411`	`{`
`413`	`412`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`414`	`413`	`if (name == null) throw new ArgumentNullException(nameof(name));`
`415`	`414`
`416`	`415`	`return Dispatcher.QueryReadAndWait(new Queries<TKey>.HashGet(key, name), static (q, s) => q.Execute(s));`
`417`	`416`	`}`
`418`	`417`
`419`		`- public override List<string> GetAllItemsFromList([NotNull] string key)`
	`418`	`+ public override List<string> GetAllItemsFromList(string key)`
`420`	`419`	`{`
`421`	`420`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`422`	`421`
`423`	`422`	`return Dispatcher.QueryReadAndWait(new Queries<TKey>.ListGetAll(key), static (q, s) => q.Execute(s));`
`424`	`423`	`}`
`425`	`424`
`426`		`- public override List<string> GetRangeFromList([NotNull] string key, int startingFrom, int endingAt)`
	`425`	`+ public override List<string> GetRangeFromList(string key, int startingFrom, int endingAt)`
`427`	`426`	`{`
`428`	`427`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`429`	`428`	`if (startingFrom < 0) throw new ArgumentException("The value must be greater than or equal to zero.", nameof(startingFrom));`
`@@ -432,7 +431,7 @@ public override List<string> GetRangeFromList([NotNull] string key, int starting`
`432`	`431`	`return Dispatcher.QueryReadAndWait(new Queries<TKey>.ListRange(key, startingFrom, endingAt), static (q, s) => q.Execute(s));`
`433`	`432`	`}`
`434`	`433`
`435`		`- public override List<string> GetRangeFromSet([NotNull] string key, int startingFrom, int endingAt)`
	`434`	`+ public override List<string> GetRangeFromSet(string key, int startingFrom, int endingAt)`
`436`	`435`	`{`
`437`	`436`	`if (key == null) throw new ArgumentNullException(nameof(key));`
`438`	`437`	`if (startingFrom < 0) throw new ArgumentException("The value must be greater than or equal to zero.", nameof(startingFrom));`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,6 @@`
`18`	`18`	`using System.Diagnostics.CodeAnalysis;`
`19`	`19`	`using System.Globalization;`
`20`	`20`	`using System.Linq;`
`21`		`-using Hangfire.Annotations;`
`22`	`21`	`using Hangfire.Common;`
`23`	`22`	`using Hangfire.InMemory.State;`
`24`	`23`	`using Hangfire.States;`
`@@ -54,7 +53,7 @@ internal sealed class InMemoryMonitoringApi<TKey> : JobStorageMonitor`
`54`	`53`	`private readonly DispatcherBase<TKey> _dispatcher;`
`55`	`54`	`private readonly IKeyProvider<TKey> _keyProvider;`
`56`	`55`
`57`		`- public InMemoryMonitoringApi([NotNull] DispatcherBase<TKey> dispatcher, [NotNull] IKeyProvider<TKey> keyProvider)`
	`56`	`+ public InMemoryMonitoringApi(DispatcherBase<TKey> dispatcher, IKeyProvider<TKey> keyProvider)`
`58`	`57`	`{`
`59`	`58`	`_dispatcher = dispatcher ?? throw new ArgumentNullException(nameof(dispatcher));`
`60`	`59`	`_keyProvider = keyProvider ?? throw new ArgumentNullException(nameof(keyProvider));`
`@@ -107,7 +106,7 @@ public override IList<ServerDto> Servers()`
`107`	`106`	`}).ToList();`
`108`	`107`	`}`
`109`	`108`
`110`		`- public override JobDetailsDto? JobDetails([NotNull] string jobId)`
	`109`	`+ public override JobDetailsDto? JobDetails(string jobId)`
`111`	`110`	`{`
`112`	`111`	`if (jobId == null) throw new ArgumentNullException(nameof(jobId));`
`113`	`112`
`@@ -165,7 +164,7 @@ public override StatisticsDto GetStatistics()`
`165`	`164`	`};`
`166`	`165`	`}`
`167`	`166`
`168`		`- public override JobList<EnqueuedJobDto> EnqueuedJobs([NotNull] string queue, int from, int perPage)`
	`167`	`+ public override JobList<EnqueuedJobDto> EnqueuedJobs(string queue, int from, int perPage)`
`169`	`168`	`{`
`170`	`169`	`if (queue == null) throw new ArgumentNullException(nameof(queue));`
`171`	`170`
`@@ -190,7 +189,7 @@ public override JobList<EnqueuedJobDto> EnqueuedJobs([NotNull] string queue, int`
`190`	`189`	`})));`
`191`	`190`	`}`
`192`	`191`
`193`		`- public override JobList<FetchedJobDto> FetchedJobs([NotNull] string queue, int from, int perPage)`
	`192`	`+ public override JobList<FetchedJobDto> FetchedJobs(string queue, int from, int perPage)`
`194`	`193`	`{`
`195`	`194`	`if (queue == null) throw new ArgumentNullException(nameof(queue));`
`196`	`195`	`return new JobList<FetchedJobDto>([]);`
`@@ -380,13 +379,13 @@ public override long ScheduledCount()`
`380`	`379`	`return GetCountByStateName(ScheduledState.StateName);`
`381`	`380`	`}`
`382`	`381`
`383`		`- public override long EnqueuedCount([NotNull] string queue)`
	`382`	`+ public override long EnqueuedCount(string queue)`
`384`	`383`	`{`
`385`	`384`	`if (queue == null) throw new ArgumentNullException(nameof(queue));`
`386`	`385`	`return _dispatcher.QueryReadAndWait(new MonitoringQueries<TKey>.QueueGetCount(queue), static (q, s) => q.Execute(s));`
`387`	`386`	`}`
`388`	`387`
`389`		`- public override long FetchedCount([NotNull] string queue)`
	`388`	`+ public override long FetchedCount(string queue)`
`390`	`389`	`{`
`391`	`390`	`if (queue == null) throw new ArgumentNullException(nameof(queue));`
`392`	`391`	`return 0;`