Skip to content

Commit 68dc649

Browse files
docs: narrow env-var notes to OAuth scope, defer Fabric mechanics to Harper docs
Remove CI/CD injection guidance (belongs with deploy-CLI credentials, not runtime secrets). Replace with a pointer to Harper Fabric documentation for managing runtime env vars. Preserve local-dev framing and .env warning. Addresses review feedback on PR #55. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent c8806e2 commit 68dc649

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export OAUTH_GITHUB_CLIENT_ID="your-client-id"
3939
export OAUTH_GITHUB_CLIENT_SECRET="your-client-secret"
4040
```
4141

42-
> **Note:** The `export` commands above are for local development and quick testing only. You can also use a `.env` file with `dotenv-cli` for local dev — just don't commit it. For **Harper Fabric** deployments, inject secrets through your CI/CD pipeline as environment variables (e.g., GitHub repository secrets passed via the `env:` block in your workflow) rather than committing them to any file.
42+
> **Note:** The `export` commands above are for local development and quick testing only. You can also use a `.env` file with `dotenv-cli` for local dev — just don't commit it. For **Harper Fabric** deployments, see the [Harper Fabric documentation](https://docs.harperdb.io/docs/fabric/managing-applications) for managing runtime environment variables.
4343
4444
### 3. Configure OAuth Callback
4545

docs/getting-started.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ export OAUTH_GITHUB_CLIENT_SECRET="your_github_client_secret"
3434

3535
> **Note:** These `export` commands are for local development only. You can also use a `.env` file with `dotenv-cli` for local dev — just don't commit it to source control.
3636
>
37-
> For **Harper Fabric** deployments, inject secrets through your CI/CD pipeline as environment variables (e.g., GitHub repository secrets passed via the `env:` block in your workflow) rather than committing them to any file.
37+
> For **Harper Fabric** deployments, your app-root `.env` is deployed alongside your component, so the same `.env` you use locally works in production — see the [Harper Fabric documentation](https://docs.harperdb.io/docs/fabric/managing-applications) for managing runtime environment variables.
3838
3939
### 3. (Optional) Register Lifecycle Hooks
4040

0 commit comments

Comments
 (0)