From 99209ad8c646442248852f19dbec362f3350a103 Mon Sep 17 00:00:00 2001 From: Nathan Heskew Date: Mon, 20 Apr 2026 09:24:19 -0700 Subject: [PATCH] workflow: bump max-turns to 16 and skip lockfile/bump diffs MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #43 (Harper v5 migration) hit max_turns=8 with zero permission denials — Claude was doing real review work but ran out of budget on a 9000-line diff dominated by package-lock.json regen. Two changes: 1. `--max-turns 8` → `--max-turns 16`. Gives headroom for substantive PRs. A single run at 8 turns cost ~$0.23; at 16 it could go higher but we still have concurrency-1 per PR and a 10-min timeout. OK. 2. Prompt now tells Claude to skip mechanical diffs: lockfiles, dep version bumps (unless they change engines/peerDeps or add new deps), and dist/ output. Keeps review focused on source. Co-Authored-By: Claude Opus 4.7 (1M context) --- .github/workflows/claude-review.yml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/.github/workflows/claude-review.yml b/.github/workflows/claude-review.yml index 98b7a1a..da5b529 100644 --- a/.github/workflows/claude-review.yml +++ b/.github/workflows/claude-review.yml @@ -37,7 +37,7 @@ jobs: show_full_output: true # TEMP: keep on during calibration so tool denials are visible; revert once reviews run cleanly claude_args: | --model claude-sonnet-4-6 - --max-turns 8 + --max-turns 16 --allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Read,Grep,Glob" prompt: | REPO: ${{ github.repository }} @@ -45,6 +45,19 @@ jobs: The PR branch is already checked out in the current working directory. + ## What to ignore in the diff + + Skip mechanical, non-reviewable diffs — they waste turns + and add no signal: + + - `package-lock.json`, `bun.lock`, `yarn.lock` — lockfile + regens are deterministic from `package.json` + - `package.json` changes that are ONLY version bumps of + existing deps (patch/minor). If `engines`, `peerDependencies`, + or new `dependencies` entries change, DO review those. + - `dist/` compiled output (shouldn't be in PRs, but if it + is, ignore it — source is the source of truth) + ## Tools For file inspection use the `Read`, `Grep`, and `Glob` tools.