diff --git a/package.json b/package.json index c3ef90f3e..323a8d4e5 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "harperdb-studio", - "version": "4.3.4", + "version": "4.3.5", "description": "A UI for HarperDB", "deploymentUrl": "studio.harperdb.io", "private": true, diff --git a/src/components/instance/browse/index.js b/src/components/instance/browse/index.js index 197a4020d..540f8dbe5 100644 --- a/src/components/instance/browse/index.js +++ b/src/components/instance/browse/index.js @@ -39,7 +39,7 @@ function NoPrimaryKeyMessage({ table }) { No Primary Key - The table { `'${table}'` } does not have a primary key. The HarperDB Studio does not currently support tables wihtout a primary key defined. Please see the HarperDB documention to see the standard HarperDB querying options. + The table { `'${table}'` } does not have a primary key. The HarperDB Studio does not currently support tables without a primary key defined. Please see the HarperDB documention to see the standard HarperDB querying options. @@ -92,7 +92,7 @@ function BrowseIndex() { * FIXME: There is a fair amount of logic scattered throughout this * page that could be put in a router-level validation function. * - * Splitting the browse endpoint into /schema/ and /schema/table heirarchy + * Splitting the browse endpoint into /schema/ and /schema/table hierarchy * might ease this. * */ @@ -162,18 +162,16 @@ function BrowseIndex() { onError={(error, componentStack) => addError({ error: { message: error.message, componentStack } })} FallbackComponent={ErrorFallback}> { - hasHashAttr ? ( - schema && table && action === 'csv' && entities.activeTable ? ( - - ) : schema && table && action && entities.activeTable ? ( - - ) : schema && table && entities.activeTable ? ( - - ) : ( - } /> - ) + schema && table && action === 'csv' && entities.activeTable ? ( + + ) : schema && table && action && entities.activeTable ? ( + + ) : schema && table && entities.activeTable ? ( + + ) : schema && table && !hasHashAttr ? ( + ) : - + } /> } diff --git a/src/components/instance/replication/manage/InstanceManager.js b/src/components/instance/replication/manage/InstanceManager.js index 31a9d0042..c4b6d5aba 100644 --- a/src/components/instance/replication/manage/InstanceManager.js +++ b/src/components/instance/replication/manage/InstanceManager.js @@ -27,24 +27,20 @@ function InstanceManager({ items, itemType, setShowModal, loading, setLoading, r const handleAddNode = useCallback( async (payload) => { setLoading(payload.compute_stack_id); - if (payload.instance_host === 'localhost') { - alert.error("External instances cannot reach that instance's URL"); - } else { - const result = - clusterEngine === 'nats' - ? await clusterSetRoutes({ auth, url, routes: [{ host: payload.instance_host, port: payload.clusterPort }] }) - : await addNode({ ...payload, auth, url, is_local, customer_id }); + const result = + clusterEngine === 'nats' + ? await clusterSetRoutes({ auth, url, routes: [{ host: payload.instance_host, port: payload.clusterPort }] }) + : await addNode({ ...payload, auth, url, is_local, customer_id }); - if (result.error) { - // TODO: review our policy about connecting to localhost instances. - alert.error(payload.instance_host === 'localhost' ? "External instances cannot reach that instance's URL" : result.message); - setLoading(false); - } else { - if (clusterEngine === 'nats') { - await restartService({ auth, url, service: 'clustering config' }); - } - await refreshNetwork(); + if (result.error) { + // TODO: review our policy about connecting to localhost instances. + alert.error(payload.instance_host === 'localhost' ? "External instances cannot reach that instance's URL" : result.message); + setLoading(false); + } else { + if (clusterEngine === 'nats') { + await restartService({ auth, url, service: 'clustering config' }); } + await refreshNetwork(); } setLoading(false); },