Skip to content

Commit bdeea00

Browse files
committed
fix: Switch to newer DSSE rekor type
The intoto v001 type does not persist signatures of the DSSE envelope, as noted in sigstore/rekor#973. We introduced an intoto v002 type shortly after to fix this, but since then, we've introduced another newer type, DSSE v001, which also does not persist the attestation in Rekor (as we discourage using Rekor as storage). I also updated the verifier in slsa-framework/slsa-verifier#742 to search for both Rekor entry types. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
1 parent a66d8c0 commit bdeea00

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

signing/sigstore/rekor.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ func (r *Rekor) Upload(ctx context.Context, att signing.Attestation) (signing.Lo
8080
return nil, fmt.Errorf("creating rekor client: %w", err)
8181
}
8282
// TODO: Is it a bug that we need []byte(string(k.Cert)) or else we hit invalid PEM?
83-
logEntry, err := cosign.TLogUploadInTotoAttestation(ctx, rekorClient, att.Bytes(), []byte(string(att.Cert())))
83+
logEntry, err := cosign.TLogUploadDSSEEnvelope(ctx, rekorClient, att.Bytes(), []byte(string(att.Cert())))
8484
if err != nil {
8585
return nil, fmt.Errorf("uploading attestation: %w", err)
8686
}

0 commit comments

Comments
 (0)