goresym 2.6.3 (new formula)#155716
Merged
BrewTestBot merged 2 commits intoHomebrew:masterfrom Nov 28, 2023
Merged
Conversation
0xdevalias
commented
Nov 28, 2023
chenrui333
reviewed
Nov 28, 2023
chenrui333
approved these changes
Nov 28, 2023
Member
chenrui333
left a comment
There was a problem hiding this comment.
LGTM, just one nit comment
Contributor
Author
@chenrui333 Accepted your changes :) |
Member
|
@Oxyriser can you squash all the commits? Thanks! |
Co-Authored-By: Rui Chen <rui@chenrui.dev>
Contributor
Author
@chenrui333 I've squashed the commits and force pushed.. but honestly that really shouldn't be a blocker in the automation on this repo. PR's can be squash merged, which would solve this and other 'friction points' (like the CI blocking a PR because a certain commit within it is named poorly) without requiring manual process on each and every PR. Edit: Raised this concern in the following: |
carlocab
approved these changes
Nov 28, 2023
Member
|
@0xdevalias thanks for your contribution! 🎉 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Add new formula for
GoReSymCLI: