Vladislav savchenko#32
Merged
Merged
Conversation
jskonst
requested changes
Nov 28, 2019
| Assert.Equal(res, new double[5]); | ||
| } | ||
| [Theory] | ||
| [InlineData(2.0, 1.2, 4.2, 0.6)] |
Collaborator
There was a problem hiding this comment.
🔕 для 1 теста не надо такое писать - просто Fact, а все остальное внутри теста
| var result = new int[resultA.Length]; | ||
| foreach (var item in resultA) | ||
| { | ||
| result[k] = (int)Math.Floor(resultA[k]*1000); |
Collaborator
There was a problem hiding this comment.
Зачем это умножение на 1000?
| result[k] = (int)Math.Floor(resultA[k]*1000); | ||
| k++; | ||
| } | ||
| var exp = new int[] {24, 23, 21, 19, 17}; |
Collaborator
There was a problem hiding this comment.
Для этой задачи можно проверить просто число элементов в массиве, при условии того, что сама функция протестирована
| { | ||
| Dog snech = new Dog(); | ||
| Assert.Equal( | ||
| @" __ _ |
Collaborator
There was a problem hiding this comment.
я чего у вас собачку как скукожило?
| <TargetFramework>netcoreapp2.1</TargetFramework> | ||
| <TreatWarningsAsErrors>True</TreatWarningsAsErrors> | ||
| <TargetFramework>netcoreapp2.0</TargetFramework> | ||
| <TreatWarningsAsErrors>false</TreatWarningsAsErrors> |
| Pol = n; | ||
| if (Pol == "S") | ||
| { | ||
| Age = 12; |
Collaborator
There was a problem hiding this comment.
А где конструктор с теми параметрами, который я хочу - а вы мне генерируете собак пенсионного возраста ?
|
|
||
| public void GetInfo() | ||
| { | ||
| Console.WriteLine($"Пол: {Pol} Возраст: {Age} Вес: {Weight}"); |
Collaborator
There was a problem hiding this comment.
Замените getInfo на перекрытие toString
jskonst
requested changes
Dec 2, 2019
| @@ -1,206 +0,0 @@ | |||
| # Download this file using PowerShell v3 under Windows with the following comand: | |||
| } | ||
| return y; | ||
| } | ||
| public static double[] TaskB(double a, double[] x) |
Collaborator
There was a problem hiding this comment.
Уже переписывайте на использование списков
jskonst
requested changes
Dec 12, 2019
| <PropertyGroup> | ||
| <TargetFramework>netcoreapp2.1</TargetFramework> | ||
| <TreatWarningsAsErrors>True</TreatWarningsAsErrors> | ||
| <TreatWarningsAsErrors>False</TreatWarningsAsErrors> |
jskonst
requested changes
Dec 12, 2019
| public void Test1() | ||
| { | ||
| Assert.True(true); | ||
| Xunit.Assert.True(true); |
|
|
||
| public void TestTaskA(double a, double xn, double xk, double dx) | ||
| { | ||
| var res = Program.TaskA(a, xn, xk, dx); |
Collaborator
There was a problem hiding this comment.
А тест нормального выполнения функции?
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>netcoreapp2.1</TargetFramework> | ||
| <TreatWarningsAsErrors>True</TreatWarningsAsErrors> | ||
| <TreatWarningsAsErrors>False</TreatWarningsAsErrors> |
jskonst
requested changes
Dec 16, 2019
|
|
||
| public void AgeUp() | ||
| { | ||
| this.age++; |
Collaborator
There was a problem hiding this comment.
Устанавливать надо свойство а не поле
jskonst
approved these changes
Dec 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.