Skip to content

Aleksandr enivatov#44

Merged
jskonst merged 19 commits into
ISUCT:Aleksandr_Enivatovfrom
Enik3:Aleksandr_Enivatov
Dec 26, 2019
Merged

Aleksandr enivatov#44
jskonst merged 19 commits into
ISUCT:Aleksandr_Enivatovfrom
Enik3:Aleksandr_Enivatov

Conversation

@Enik3
Copy link
Copy Markdown

@Enik3 Enik3 commented Dec 16, 2019

No description provided.

Comment thread CourseApp/Dog.cs
Comment thread CourseApp/Dog.cs
}
else
{
throw new System.Exception();
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в смысле? нельзя пол кроме male установить?

Comment thread CourseApp/Dog.cs Outdated
this.age++;
}

public override string Vote()
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Голосовать?

Comment thread CourseApp/Tiger.cs
}
else
{
throw new System.Exception();
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

То же самое

Comment thread CourseApp/Tiger.cs Outdated

set
{
if (value >= 1 && value < 10)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если у вас оба животных с одинаковым ограничением по возрасту -> надо в базовый класс это выносить, а лучше просто привести с другим возрастом

Comment thread CourseApp/Tiger.cs Outdated

public override string ToString()
{
return $"Имя:{Name},Возраст:{Age},Пол:{Sex}";
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToString тоже явный кандидат, чтобы или его переопределить и возвращать строки по другому или же вернуть это все в базовый класс

Comment thread CourseApp/SuperAnimals.cs Outdated

public virtual string VirtualView()
{
return "Virtual Metod";
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Comment thread CourseApp/Dog.cs Outdated
public Dog(string name, int age, string sex)
: base(name, age, sex)
{
Name = name;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔪

@jskonst jskonst merged commit ba7fb0b into ISUCT:Aleksandr_Enivatov Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants