Skip to content

Feature/map reorg#19

Merged
egrace479 merged 5 commits into
mainfrom
feature/map-reorg
Jun 30, 2023
Merged

Feature/map reorg#19
egrace479 merged 5 commits into
mainfrom
feature/map-reorg

Conversation

@egrace479
Copy link
Copy Markdown
Member

@egrace479 egrace479 commented Jun 28, 2023

  • Adds map into Dashboard. Access map in the distribution section through the Map View button (return to histogram with Show Histogram button. Each has different display options set in components/divs.py.
  • Graphing functions (for histogram and pie chart) are now in components/graphs.py with the map function. DataFrame manipulation and image retrieval functions are in components/query.py.
  • Set fixed values at top of dashboard file for div styling.
  • Removed prototype components from components folder, and removed reference to them from README.
  • Updated preview images (one with histogram and one with map) in README.
  • Addresses Issues Add Map showing distribution of data #9 and Look into reducing code duplication #13

…feature display options (divs), moved graphing functions, dataframe manipulation, and image retrieval functions to graph and query files
@johnbradley
Copy link
Copy Markdown
Contributor

johnbradley commented Jun 30, 2023

This change adds a new button that switches between the Map View and the Histogram View.


The top part of the Map View looks like this:
Screen Shot 2023-06-30 at 1 26 26 PM


The top part of the Histogram View looks like this:
Screen Shot 2023-06-30 at 1 26 41 PM

I found it a little surprising how the whole screen switched around when clicking this button.
I'm wondering if there is a better location or perhaps a tab control to make it more obvious what clicking it does.

@hlapp
Copy link
Copy Markdown
Member

hlapp commented Jun 30, 2023

I agree the UX of switching the view has considerable room for improvement. But I would caution us to keep in mind the context we're still in, namely that of putting together a sufficiently functional prototype, not (yet) that of actual product development.

Perhaps there's an easy enough way to improve the UX on this, but if not, I'd argue allowing a user to submit or specify their own dataset should be the higher order of priority in terms of getting ready for the Image Datapalooza.

Copy link
Copy Markdown
Contributor

@johnbradley johnbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a suggestion for a better button name and some there are a few randomly left in commented out bits of code you may want to remove.

Comment thread dashboard.py Outdated
Comment thread components/divs.py Outdated
Comment thread components/divs.py Outdated
Comment thread components/divs.py Outdated
Comment thread components/divs.py Outdated
egrace479 and others added 2 commits June 30, 2023 14:50
For consistency with the other version of the switch view button, set "Show Map View".

Co-authored-by: John Bradley <johnbradley2008@gmail.com>
@egrace479
Copy link
Copy Markdown
Member Author

egrace479 commented Jun 30, 2023

...
I found it a little surprising how the whole screen switched around when clicking this button. I'm wondering if there is a better location or perhaps a tab control to make it more obvious what clicking it does.

I definitely agree that the layout for that quadrant could use some improvement, and I set up an issue (#21) to brainstorm solutions. I also agree with @hlapp that functionality for Image Datapalooza needs to be prioritized.

@hlapp
Copy link
Copy Markdown
Member

hlapp commented Jun 30, 2023

BTW @egrace479 given that there've already been two pairs of eagle eyes, I'm not sure there's anything I can add, so please don't wait for my review or approval.

@egrace479 egrace479 merged commit 2f4adca into main Jun 30, 2023
@egrace479 egrace479 deleted the feature/map-reorg branch August 3, 2023 21:35
@egrace479 egrace479 restored the feature/map-reorg branch August 3, 2023 21:35
@egrace479 egrace479 deleted the feature/map-reorg branch August 3, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants